From: Eric Sandeen <sandeen@sandeen.net>
To: Pavel Reichl <preichl@redhat.com>, Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/2] mkfs: Show progress during block discard
Date: Fri, 22 Nov 2019 15:19:15 -0600 [thread overview]
Message-ID: <0f541515-cb1f-985a-f352-0c3af78a0388@sandeen.net> (raw)
In-Reply-To: <CAJc7PzVBcjXc5uBgyT_XiX1ffaoRTe8jkWmSq-F8pZqezpEnGA@mail.gmail.com>
On 11/22/19 10:43 AM, Pavel Reichl wrote:
> On Fri, Nov 22, 2019 at 12:42 AM Dave Chinner <david@fromorbit.com> wrote:
>>
>> On Thu, Nov 21, 2019 at 10:44:45PM +0100, Pavel Reichl wrote:
...
>>
>> I also suspect that it breaks a few fstests, too, as a some of them
>> capture and filter mkfs output. They'll need filters to drop these
>> new messages.
>>
>> FWIW, a 100 lines of extra mkfs output is going to cause workflow
>> issues. I know it will cause me problems, because I often mkfs 500TB
>> filesystems tens of times a day on a discard enabled device. This
>> extra output will scroll all the context of the previous test run
>> I'm about to compare against off my terminal screen and so now I
>> will have to scroll the terminal to look at the results of
>> back-to-back runs. IOWs, I'm going to immediately want to turn this
>> output off and have it stay off permanently.
>>
>> Hence I think that, by default, just outputting a single "Discard in
>> progress" line before starting the discard would be sufficient
e2fsprogs simply does:
Discarding device blocks: done
("done" isn't printed until it's ... done)
so that might be a good convention to follow? Though I'd probably do
printf("Discarding blocks... ");
....
printf("Done.\n");
because the ellipses tend to indicate waiting. :)
Even the one line might require filtering-out in xfstests, but luckily we have
standard filters and it should be trivial to add.
> OK, maybe just one line "Discard in progress" is actually what users
> need. The computing of % done was probably just overkill from my side.
> Sorry about that.
No worries, that's why we discuss stuff. :)
Thanks for taking this on,
-Eric
prev parent reply other threads:[~2019-11-22 21:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 21:44 [PATCH 0/2] mkfs: inform during block discarding Pavel Reichl
2019-11-21 21:44 ` [PATCH 1/2] mkfs: Break block discard into chunks of 2 GB Pavel Reichl
2019-11-21 21:55 ` Darrick J. Wong
2019-11-22 14:46 ` Pavel Reichl
2019-11-22 21:07 ` Eric Sandeen
2019-11-21 23:18 ` Dave Chinner
2019-11-22 15:38 ` Darrick J. Wong
2019-11-22 15:59 ` Pavel Reichl
2019-11-22 21:00 ` Dave Chinner
2019-11-22 16:09 ` Pavel Reichl
2019-11-22 21:10 ` Eric Sandeen
2019-11-22 21:30 ` Eric Sandeen
2019-11-26 19:40 ` Eric Sandeen
2019-11-26 20:53 ` Eric Sandeen
2019-11-21 21:44 ` [PATCH 2/2] mkfs: Show progress during block discard Pavel Reichl
2019-11-21 21:59 ` Darrick J. Wong
2019-11-22 16:27 ` Pavel Reichl
2019-11-22 16:31 ` Darrick J. Wong
2019-11-21 23:41 ` Dave Chinner
2019-11-22 16:43 ` Pavel Reichl
2019-11-22 21:11 ` Dave Chinner
2019-11-22 21:19 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f541515-cb1f-985a-f352-0c3af78a0388@sandeen.net \
--to=sandeen@sandeen.net \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
--cc=preichl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).