linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Xiaoli Feng <xifeng@redhat.com>
To: Eryu Guan <guaneryu@gmail.com>
Cc: esandeen@redhat.com, jmoyer@redhat.com, fstests@vger.kernel.org,
	xzhou@redhat.com, linux-xfs@vger.kernel.org,
	chandan@linux.vnet.ibm.com
Subject: Re: [PATCH v1] xfs/050: make it passed for dax 2 MiB alignment test
Date: Thu, 15 Nov 2018 02:19:10 -0500 (EST)	[thread overview]
Message-ID: <1047154516.51611825.1542266350177.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20181104161554.GF12788@desktop>

Hello all,
  Any thoughts for this patch? Adding chandan@linux.vnet.ibm.com to cc list for review. 
Because his patch "xfs/050: work with 64k block size" change the bsoft and bhard size.

Thanks.

----- Original Message -----
> From: "Eryu Guan" <guaneryu@gmail.com>
> To: "XiaoLi Feng" <xifeng@redhat.com>
> Cc: esandeen@redhat.com, jmoyer@redhat.com, fstests@vger.kernel.org, xzhou@redhat.com, linux-xfs@vger.kernel.org
> Sent: Monday, November 5, 2018 12:15:54 AM
> Subject: Re: [PATCH v1] xfs/050: make it passed for dax 2 MiB alignment test
> 
> On Fri, Oct 26, 2018 at 10:47:54AM +0800, Xiaoli Feng wrote:
> > From: xiaoli feng <xifeng@redhat.com>
> > 
> > This case is failed for dax 2MiB alignment test. When test "push past
> > the hard block limit" in this case, the quota bhard is 4000kb, and
> > try to create 4096kb in dax fs. dax only create 2048kb because of 2MiB
> > alignment. But there is a check that the file size must > 3400kb(bhard
> > * 85%). So there are two method to fix it. One is to decrease bhard
> > size. Second is to descreate minimum size. The minimum is hard to define.
> > So I choose first method.
> 
> Adding linux-xfs to cc list for review from xfs folks. Thanks a lot!
> 
> Eryu
> 
> > ---
> >  tests/xfs/050     |  4 ++--
> >  tests/xfs/050.out | 60
> >  +++++++++++++++++++++++++++----------------------------
> >  2 files changed, 32 insertions(+), 32 deletions(-)
> > 
> > diff --git a/tests/xfs/050 b/tests/xfs/050
> > index 788ed7f..d2ca477 100755
> > --- a/tests/xfs/050
> > +++ b/tests/xfs/050
> > @@ -43,8 +43,8 @@ _scratch_mount
> >  bsize=$(_get_file_block_size $SCRATCH_MNT)
> >  _scratch_unmount
> >  
> > -bsoft=$(( 200 * $bsize ))
> > -bhard=$(( 1000 * $bsize ))
> > +bsoft=$(( 100 * $bsize ))
> > +bhard=$(( 500 * $bsize ))
> >  isoft=4
> >  ihard=10
> >  
> > diff --git a/tests/xfs/050.out b/tests/xfs/050.out
> > index 725cd79..6a7af1a 100644
> > --- a/tests/xfs/050.out
> > +++ b/tests/xfs/050.out
> > @@ -12,23 +12,23 @@ realtime =RDEV extsz=XXX blocks=XXX, rtextents=XXX
> >  
> >  *** report initial settings
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] 0 200 1000 00 [--------] 1 4 10 00 [--------] 0 0 0 00 [--------]
> > +[NAME] 0 100 500 00 [--------] 1 4 10 00 [--------] 0 0 0 00 [--------]
> >  
> >  *** push past the soft inode limit
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] 0 200 1000 00 [--------] 5 4 10 00 [7 days] 0 0 0 00 [--------]
> > +[NAME] 0 100 500 00 [--------] 5 4 10 00 [7 days] 0 0 0 00 [--------]
> >  
> >  *** push past the soft block limit
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] 300 200 1000 00 [7 days] 6 4 10 00 [7 days] 0 0 0 00 [--------]
> > +[NAME] 300 100 500 00 [7 days] 6 4 10 00 [7 days] 0 0 0 00 [--------]
> >  
> >  *** push past the hard inode limit (expect EDQUOT)
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] 300 200 1000 00 [7 days] 10 4 10 00 [7 days] 0 0 0 00 [--------]
> > +[NAME] 300 100 500 00 [7 days] 10 4 10 00 [7 days] 0 0 0 00 [--------]
> >  
> >  *** push past the hard block limit (expect EDQUOT)
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] =OK= 200 1000 0 [7 days] 10 4 10 00 [7 days] 0 0 0 00 [--------]
> > +[NAME] =OK= 100 500 0 [7 days] 10 4 10 00 [7 days] 0 0 0 00 [--------]
> >  
> >  *** unmount
> >  *** group
> > @@ -44,23 +44,23 @@ realtime =RDEV extsz=XXX blocks=XXX, rtextents=XXX
> >  
> >  *** report initial settings
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] 0 200 1000 00 [--------] 1 4 10 00 [--------] 0 0 0 00 [--------]
> > +[NAME] 0 100 500 00 [--------] 1 4 10 00 [--------] 0 0 0 00 [--------]
> >  
> >  *** push past the soft inode limit
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] 0 200 1000 00 [--------] 5 4 10 00 [7 days] 0 0 0 00 [--------]
> > +[NAME] 0 100 500 00 [--------] 5 4 10 00 [7 days] 0 0 0 00 [--------]
> >  
> >  *** push past the soft block limit
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] 300 200 1000 00 [7 days] 6 4 10 00 [7 days] 0 0 0 00 [--------]
> > +[NAME] 300 100 500 00 [7 days] 6 4 10 00 [7 days] 0 0 0 00 [--------]
> >  
> >  *** push past the hard inode limit (expect EDQUOT)
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] 300 200 1000 00 [7 days] 10 4 10 00 [7 days] 0 0 0 00 [--------]
> > +[NAME] 300 100 500 00 [7 days] 10 4 10 00 [7 days] 0 0 0 00 [--------]
> >  
> >  *** push past the hard block limit (expect EDQUOT)
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] =OK= 200 1000 0 [7 days] 10 4 10 00 [7 days] 0 0 0 00 [--------]
> > +[NAME] =OK= 100 500 0 [7 days] 10 4 10 00 [7 days] 0 0 0 00 [--------]
> >  
> >  *** unmount
> >  *** uqnoenforce
> > @@ -76,23 +76,23 @@ realtime =RDEV extsz=XXX blocks=XXX, rtextents=XXX
> >  
> >  *** report initial settings
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] 0 200 1000 00 [--------] 1 4 10 00 [--------] 0 0 0 00 [--------]
> > +[NAME] 0 100 500 00 [--------] 1 4 10 00 [--------] 0 0 0 00 [--------]
> >  
> >  *** push past the soft inode limit
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] 0 200 1000 00 [--------] 5 4 10 00 [--------] 0 0 0 00 [--------]
> > +[NAME] 0 100 500 00 [--------] 5 4 10 00 [--------] 0 0 0 00 [--------]
> >  
> >  *** push past the soft block limit
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] 300 200 1000 00 [--------] 6 4 10 00 [--------] 0 0 0 00 [--------]
> > +[NAME] 300 100 500 00 [--------] 6 4 10 00 [--------] 0 0 0 00 [--------]
> >  
> >  *** push past the hard inode limit (expect EDQUOT)
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] 300 200 1000 00 [--------] 18 4 10 00 [--none--] 0 0 0 00
> > [--------]
> > +[NAME] 300 100 500 00 [--------] 18 4 10 00 [--none--] 0 0 0 00 [--------]
> >  
> >  *** push past the hard block limit (expect EDQUOT)
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] 1200 200 1000 00 [--none--] 18 4 10 00 [--none--] 0 0 0 00
> > [--------]
> > +[NAME] 1200 100 500 00 [--none--] 18 4 10 00 [--none--] 0 0 0 00
> > [--------]
> >  
> >  *** unmount
> >  *** gqnoenforce
> > @@ -108,23 +108,23 @@ realtime =RDEV extsz=XXX blocks=XXX, rtextents=XXX
> >  
> >  *** report initial settings
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] 0 200 1000 00 [--------] 1 4 10 00 [--------] 0 0 0 00 [--------]
> > +[NAME] 0 100 500 00 [--------] 1 4 10 00 [--------] 0 0 0 00 [--------]
> >  
> >  *** push past the soft inode limit
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] 0 200 1000 00 [--------] 5 4 10 00 [--------] 0 0 0 00 [--------]
> > +[NAME] 0 100 500 00 [--------] 5 4 10 00 [--------] 0 0 0 00 [--------]
> >  
> >  *** push past the soft block limit
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] 300 200 1000 00 [--------] 6 4 10 00 [--------] 0 0 0 00 [--------]
> > +[NAME] 300 100 500 00 [--------] 6 4 10 00 [--------] 0 0 0 00 [--------]
> >  
> >  *** push past the hard inode limit (expect EDQUOT)
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] 300 200 1000 00 [--------] 18 4 10 00 [--none--] 0 0 0 00
> > [--------]
> > +[NAME] 300 100 500 00 [--------] 18 4 10 00 [--none--] 0 0 0 00 [--------]
> >  
> >  *** push past the hard block limit (expect EDQUOT)
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] 1200 200 1000 00 [--none--] 18 4 10 00 [--none--] 0 0 0 00
> > [--------]
> > +[NAME] 1200 100 500 00 [--none--] 18 4 10 00 [--none--] 0 0 0 00
> > [--------]
> >  
> >  *** unmount
> >  *** pquota
> > @@ -140,23 +140,23 @@ realtime =RDEV extsz=XXX blocks=XXX, rtextents=XXX
> >  
> >  *** report initial settings
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] 0 200 1000 00 [--------] 1 4 10 00 [--------] 0 0 0 00 [--------]
> > +[NAME] 0 100 500 00 [--------] 1 4 10 00 [--------] 0 0 0 00 [--------]
> >  
> >  *** push past the soft inode limit
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] 0 200 1000 00 [--------] 5 4 10 00 [7 days] 0 0 0 00 [--------]
> > +[NAME] 0 100 500 00 [--------] 5 4 10 00 [7 days] 0 0 0 00 [--------]
> >  
> >  *** push past the soft block limit
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] 300 200 1000 00 [7 days] 6 4 10 00 [7 days] 0 0 0 00 [--------]
> > +[NAME] 300 100 500 00 [7 days] 6 4 10 00 [7 days] 0 0 0 00 [--------]
> >  
> >  *** push past the hard inode limit (expect EDQUOT)
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] 300 200 1000 00 [7 days] 9 4 10 00 [7 days] 0 0 0 00 [--------]
> > +[NAME] 300 100 500 00 [7 days] 9 4 10 00 [7 days] 0 0 0 00 [--------]
> >  
> >  *** push past the hard block limit (expect EDQUOT)
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] =OK= 200 1000 0 [7 days] 9 4 10 00 [7 days] 0 0 0 00 [--------]
> > +[NAME] =OK= 100 500 0 [7 days] 9 4 10 00 [7 days] 0 0 0 00 [--------]
> >  
> >  *** unmount
> >  *** pqnoenforce
> > @@ -172,22 +172,22 @@ realtime =RDEV extsz=XXX blocks=XXX, rtextents=XXX
> >  
> >  *** report initial settings
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] 0 200 1000 00 [--------] 1 4 10 00 [--------] 0 0 0 00 [--------]
> > +[NAME] 0 100 500 00 [--------] 1 4 10 00 [--------] 0 0 0 00 [--------]
> >  
> >  *** push past the soft inode limit
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] 0 200 1000 00 [--------] 5 4 10 00 [--------] 0 0 0 00 [--------]
> > +[NAME] 0 100 500 00 [--------] 5 4 10 00 [--------] 0 0 0 00 [--------]
> >  
> >  *** push past the soft block limit
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] 300 200 1000 00 [--------] 6 4 10 00 [--------] 0 0 0 00 [--------]
> > +[NAME] 300 100 500 00 [--------] 6 4 10 00 [--------] 0 0 0 00 [--------]
> >  
> >  *** push past the hard inode limit (expect EDQUOT)
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] 300 200 1000 00 [--------] 18 4 10 00 [--none--] 0 0 0 00
> > [--------]
> > +[NAME] 300 100 500 00 [--------] 18 4 10 00 [--none--] 0 0 0 00 [--------]
> >  
> >  *** push past the hard block limit (expect EDQUOT)
> >  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> > -[NAME] 1200 200 1000 00 [--none--] 18 4 10 00 [--none--] 0 0 0 00
> > [--------]
> > +[NAME] 1200 100 500 00 [--none--] 18 4 10 00 [--none--] 0 0 0 00
> > [--------]
> >  
> >  *** unmount
> > --
> > 1.8.3.1
> > 
> 

  reply	other threads:[~2018-11-15 17:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1540522074-20036-1-git-send-email-xifeng@redhat.com>
2018-11-04 16:15 ` [PATCH v1] xfs/050: make it passed for dax 2 MiB alignment test Eryu Guan
2018-11-15  7:19   ` Xiaoli Feng [this message]
2018-11-20  8:56     ` Chandan Rajendra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1047154516.51611825.1542266350177.JavaMail.zimbra@redhat.com \
    --to=xifeng@redhat.com \
    --cc=chandan@linux.vnet.ibm.com \
    --cc=esandeen@redhat.com \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=jmoyer@redhat.com \
    --cc=linux-xfs@vger.kernel.org \
    --cc=xzhou@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).