From: Eric Sandeen <sandeen@sandeen.net>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
Pavel Reichl <preichl@redhat.com>,
"linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH v3] mkfs: Break block discard into chunks of 2 GB
Date: Wed, 4 Dec 2019 10:24:32 -0600 [thread overview]
Message-ID: <1051488a-7f91-5506-9959-ff2812edc9e1@sandeen.net> (raw)
In-Reply-To: <BYAPR04MB5749DD0BFA3B6928A87E54B086410@BYAPR04MB5749.namprd04.prod.outlook.com>
On 11/30/19 4:01 PM, Chaitanya Kulkarni wrote:
> Not an XFS expert, but patch to handle ^C is been discussed on the
> block layer mailing list which includes discard operations. [1]
>
> This solution seems specific to one file system, which will lead to
> code repetition for all the file systems which are in question.
>
> How about we come up with the generic solution in the block-layer so
> it can be reused for all the file systems ?
>
> (fyi, I'm not aware of any drawbacks of handling ^C it in the block
> layer and would like to learn if any).
>
> [1] https://patchwork.kernel.org/patch/11234607/
>
> -Chaitanya
It'd be great to fix this universally in the kernel but it seems like
that patch is in discussion for now, and TBH I don't see any real
drawbacks to looping in mkfs - it would also solve the problem on any
old kernel w/o the block layer change.
I'd propose that we go ahead w/ the mkfs change, and if/when the kernel
handles this better, and it's reasonable to expect that we're running
on a kernel where it can be interrupted, we could remove the mkfs loop
at a later date if we wanted to.
-Eric
next prev parent reply other threads:[~2019-12-04 16:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 6:21 [PATCH v3] mkfs: Break block discard into chunks of 2 GB Pavel Reichl
2019-11-30 22:01 ` Chaitanya Kulkarni
2019-12-02 16:40 ` Darrick J. Wong
2019-12-04 16:24 ` Eric Sandeen [this message]
2019-12-04 17:26 ` Christoph Hellwig
2019-12-04 17:32 ` Eric Sandeen
2019-12-04 17:42 ` Darrick J. Wong
2019-12-10 7:33 ` Chaitanya Kulkarni
2019-12-10 14:20 ` Eric Sandeen
2019-12-09 22:00 ` Eric Sandeen
2019-12-09 23:34 ` Darrick J. Wong
2019-12-10 0:49 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1051488a-7f91-5506-9959-ff2812edc9e1@sandeen.net \
--to=sandeen@sandeen.net \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=linux-xfs@vger.kernel.org \
--cc=preichl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).