linux-xfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: guaneryu@gmail.com, darrick.wong@oracle.com
Cc: linux-xfs@vger.kernel.org, fstests@vger.kernel.org
Subject: [PATCH 0/7] fstests: fix quota failures on xfs
Date: Tue, 03 Jul 2018 21:50:47 -0700	[thread overview]
Message-ID: <153067984748.28393.1595618163831671652.stgit@magnolia> (raw)

Hi all,

Several months ago I tried testing xfs with quotas enabled and was
surprised at the number of failures.  Since then I've been on a bug hunt
to triage the mess, and the following series fixes some of the low
hanging fruit.  Some of these are minor behavioral variations when quota
are enabled, and other fixes upgrade old v4 tests to work on v5
filesystems.

To reproduce the results, run xfstests with
'MOUNT_OPTIONS="-o usrquota,grpquota,prjquota"' on a v5 filesystem.
Strike the ',grpquota' on a v4 filesystem.

The first patch fixes differences in the golden output when quotas are
enabled on xfs -- mmap writes (intentionally) crashing with SIGBUS when
quota updates fail vs. msync failing with EIO.

The second patch fixes all the tests that require a specific quota mount
option configuration to filter out any quota options present in
MOUNT_OPTIONS.

The third patch updates xfs/001 to work with XFS v5 filesystems since
there was nothing particularly v4 specific about it.

The fourth patch enables tests that require a v4 format to filter out v5
mount options (such as grpquota) so that they can run.

Patch #5 upgrades xfs/288 to support XFS v5 since there was nothing
particular to v4 about that test.

Patch #6 fixes a problem in generic/338 where switching the disk backend
to dm-error on a xfs with quotas enabled causes the fs to go down with a
dirty log which is not recovered prior to the end of the test.  This was
originally a regression test for a NULL pointer dereference after the fs
shuts down, so we can skip the post-test fsck.

Patch #7 filters 'quota info will be regenerated on next quota mount'
messages from the xfs_repair golden output.

--D

             reply	other threads:[~2018-07-04  4:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-04  4:50 Darrick J. Wong [this message]
2018-07-04  4:50 ` [PATCH 1/7] generic/{279, 28[1-3]}: hide SIGBUS reporting from golden output Darrick J. Wong
2018-07-04  4:51 ` [PATCH 2/7] misc: force the exact quota options coded into the test Darrick J. Wong
2018-07-14 10:14   ` Eryu Guan
2018-07-04  4:51 ` [PATCH 3/7] xfs/001: update to handle v5 filesystems Darrick J. Wong
2018-07-04  4:51 ` [PATCH 4/7] xfs: filter out mount options that don't work on v4 filesystems Darrick J. Wong
2018-07-14 11:41   ` Eryu Guan
2018-11-01 22:51     ` Darrick J. Wong
2018-07-04  4:51 ` [PATCH 5/7] xfs/288: update for v5 filesystem support in xfs_db Darrick J. Wong
2018-07-04  4:51 ` [PATCH 6/7] generic/338: don't check fs after crashing it Darrick J. Wong
2018-07-04  4:51 ` [PATCH 7/7] misc: filter out quota regeneration messages Darrick J. Wong
2018-07-14 11:49 ` [PATCH 0/7] fstests: fix quota failures on xfs Eryu Guan
2018-07-16 14:28   ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=153067984748.28393.1595618163831671652.stgit@magnolia \
    --to=darrick.wong@oracle.com \
    --cc=fstests@vger.kernel.org \
    --cc=guaneryu@gmail.com \
    --cc=linux-xfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).