From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADFF6C43331 for ; Fri, 6 Sep 2019 03:38:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A9BB4206B8 for ; Fri, 6 Sep 2019 03:38:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="d5qs3S7Z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392147AbfIFDiL (ORCPT ); Thu, 5 Sep 2019 23:38:11 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:44222 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392146AbfIFDiL (ORCPT ); Thu, 5 Sep 2019 23:38:11 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x863Xu3u074308; Fri, 6 Sep 2019 03:38:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : from : to : cc : date : message-id : in-reply-to : references : mime-version : content-type : content-transfer-encoding; s=corp-2019-08-05; bh=wFNAEg5YtbO6E4yspEc6n6KfAiklSqUX3m/88fxOJCs=; b=d5qs3S7ZbCrRVv7dKQd1HZ31yiDm55n22CRVpz7gH1M6JpcAZsx+kJkc1oTeURGpEoiu 9oNy/qblN583m9vXDhyPP9YEYvXbI6IWY7DdAwffn2I6mEg7DS83ZBYT4cO2aFSOeYVF xhkL+kmUvJPj0OHYYKcT0VxKIOHlmQkPt5/d2/iIOUi3WyVwOP96FwXIzWEhNmEwdHF/ /xdNAlvHFpjSqiHKQUlXSQkHNiIEGjqEkU1nYJ19tMd7KPnZNqzH3GwPBgP+AJnTb5/g wozQS5HIeBjT/yEDfZWVnjG8HiXoX3UGjyVHFOyPwfKmZ3ffqmjqbgf3R0bCo1ke9ERA /g== Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 2uuf51g3ab-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 06 Sep 2019 03:38:09 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x863XbqX069130; Fri, 6 Sep 2019 03:37:19 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userp3020.oracle.com with ESMTP id 2utvr4jwpf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 06 Sep 2019 03:37:19 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x863bJP2015507; Fri, 6 Sep 2019 03:37:19 GMT Received: from localhost (/10.159.148.70) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 05 Sep 2019 20:37:18 -0700 Subject: [PATCH 10/13] xfs_scrub: report all progressbar creation failures From: "Darrick J. Wong" To: sandeen@sandeen.net, darrick.wong@oracle.com Cc: linux-xfs@vger.kernel.org Date: Thu, 05 Sep 2019 20:37:18 -0700 Message-ID: <156774103839.2644719.4073244978058882123.stgit@magnolia> In-Reply-To: <156774097496.2644719.4441145106129821110.stgit@magnolia> References: <156774097496.2644719.4441145106129821110.stgit@magnolia> User-Agent: StGit/0.17.1-dirty MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9371 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=993 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1909060039 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9371 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1906280000 definitions=main-1909060039 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org From: Darrick J. Wong Always report failures when creating progress bars. Signed-off-by: Darrick J. Wong --- scrub/progress.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/scrub/progress.c b/scrub/progress.c index 08c7233e..5fda4ccb 100644 --- a/scrub/progress.c +++ b/scrub/progress.c @@ -198,8 +198,10 @@ progress_init_phase( } ret = pthread_create(&pt.thread, NULL, progress_report_thread, NULL); - if (ret) + if (ret) { + str_liberror(ctx, ret, _("creating progress reporting thread")); goto out_ptcounter; + } return true;