From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: darrick.wong@oracle.com
Cc: linux-xfs@vger.kernel.org, hch@infradead.org
Subject: [PATCH 0/4] xfs: refactor corruption checking and reporting
Date: Wed, 06 Nov 2019 19:01:48 -0800 [thread overview]
Message-ID: <157309570855.45542.14663613458519550414.stgit@magnolia> (raw)
Hi all,
In this second series, we refactor the code that XFS uses to determine
that it is dealing with corrupt metadata and report that to userspace.
The first patch replaces the XFS_WANT_CORRUPT* macros with open-coded
versions because it's a little strange that a thing that looks like a
simple function call actually has series effects on code flow.
The second patch cleans up all the "if (bad) { XFS_ERROR_REPORT..." code
by combining that into a single XFS_IS_CORRUPT macro that does all that
logging. This cleans up the error handling code blocks some more.
Patch three converts other metadata corruption checks to use the new
XFS_IS_CORRUPT macro.
Patch four converts some EIO-on-corruption returns that were missed in
an earlier cleanup patch.
If you're going to start using this mess, you probably ought to just
pull from my git trees, which are linked below.
This has been lightly tested with fstests. Enjoy!
Comments and questions are, as always, welcome.
--D
kernel git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=refactor-corruption-checks
xfsprogs git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfsprogs-dev.git/log/?h=refactor-corruption-checks
next reply other threads:[~2019-11-07 3:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 3:01 Darrick J. Wong [this message]
2019-11-07 3:01 ` [PATCH 1/4] xfs: add a XFS_IS_CORRUPT macro Darrick J. Wong
2019-11-07 18:16 ` Christoph Hellwig
2019-11-07 3:02 ` [PATCH 2/4] xfs: kill the XFS_WANT_CORRUPT_* macros Darrick J. Wong
2019-11-07 18:16 ` Christoph Hellwig
2019-11-07 3:02 ` [PATCH 3/4] xfs: convert open coded corruption check to use XFS_IS_CORRUPT Darrick J. Wong
2019-11-07 18:25 ` Christoph Hellwig
2019-11-07 20:57 ` Darrick J. Wong
2019-11-08 0:01 ` Darrick J. Wong
2019-11-07 3:02 ` [PATCH 4/4] xfs: convert EIO to EFSCORRUPTED when log contents are invalid Darrick J. Wong
2019-11-07 8:46 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157309570855.45542.14663613458519550414.stgit@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).