From: "Darrick J. Wong" <djwong@kernel.org>
To: djwong@kernel.org, guaneryu@gmail.com
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
Christoph Hellwig <hch@lst.de>,
linux-xfs@vger.kernel.org, fstests@vger.kernel.org, guan@eryu.me
Subject: [PATCHSET v3 0/9] fstests: document all test groups
Date: Wed, 15 Sep 2021 16:42:37 -0700 [thread overview]
Message-ID: <163174935747.380880.7635671692624086987.stgit@magnolia> (raw)
Hi all,
I've noticed that fstests doesn't document what the test groups mean. I
attempted to document what each group seems to symbolize, to reduce the
amount of confusion for new contributors. While doing so, I noticed
that there were a handful of tests that aren't in the right group. The
first three patches dix that problem. The next test adds a build-time
check to ensure that all groups are listed in the documentation file so
that we don't lose track of things. The last patch updates ./new to use
the documentation file instead of having to build group.list files.
v2: fix the 'subvolume' group tests, tweak some of the wordings of the
group description file, add missing license declarations, remove the
one-off overlay group
v2.1: move the group name documentation checks into the preamble code so we
don't have to have a second script
v3: cleanup cleanups to mkgroupfile and don't allow new 'other' group tests
If you're going to start using this mess, you probably ought to just
pull from my git trees, which are linked below.
This is an extraordinary way to destroy everything. Enjoy!
Comments and questions are, as always, welcome.
--D
fstests git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfstests-dev.git/log/?h=document-test-groups
---
common/preamble | 21 ++++++++
doc/group-names.txt | 135 +++++++++++++++++++++++++++++++++++++++++++++++++++
new | 31 ++++++------
tests/btrfs/233 | 2 -
tests/btrfs/245 | 2 -
tests/ceph/001 | 2 -
tests/ceph/002 | 2 -
tests/ceph/003 | 2 -
tests/generic/631 | 2 -
tests/xfs/491 | 2 -
tests/xfs/492 | 2 -
tests/xfs/493 | 2 -
tests/xfs/519 | 2 -
tests/xfs/520 | 2 -
tests/xfs/535 | 2 -
tests/xfs/536 | 2 -
tools/mkgroupfile | 37 +++++++++++---
tools/mvtest | 5 ++
tools/nextid | 4 +-
19 files changed, 220 insertions(+), 39 deletions(-)
create mode 100644 doc/group-names.txt
next reply other threads:[~2021-09-15 23:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 23:42 Darrick J. Wong [this message]
2021-09-15 23:42 ` [PATCH 1/9] ceph: re-tag copy_file_range as being in the copy_range group Darrick J. Wong
2021-09-16 5:51 ` Amir Goldstein
2021-09-15 23:42 ` [PATCH 2/9] xfs: move reflink tests into the clone group Darrick J. Wong
2021-09-16 5:51 ` Amir Goldstein
2021-09-15 23:42 ` [PATCH 3/9] xfs: fix incorrect fuzz test group name Darrick J. Wong
2021-09-16 5:52 ` Amir Goldstein
2021-09-15 23:42 ` [PATCH 4/9] btrfs: fix incorrect subvolume " Darrick J. Wong
2021-09-16 5:52 ` Amir Goldstein
2021-09-15 23:43 ` [PATCH 5/9] generic/631: change this test to use the 'whiteout' group Darrick J. Wong
2021-09-16 5:53 ` Amir Goldstein
2021-09-15 23:43 ` [PATCH 6/9] tools: make sure that test groups are described in the documentation Darrick J. Wong
2021-09-16 5:58 ` Amir Goldstein
2021-09-15 23:43 ` [PATCH 7/9] tools: add missing license tags to my scripts Darrick J. Wong
2021-09-16 6:06 ` Amir Goldstein
2021-09-16 21:44 ` Darrick J. Wong
2021-09-15 23:43 ` [PATCH 8/9] new: only allow documented test group names Darrick J. Wong
2021-09-16 6:10 ` Amir Goldstein
2021-09-15 23:43 ` [PATCH 9/9] new: don't allow new tests in group 'other' Darrick J. Wong
2021-09-16 6:40 ` Amir Goldstein
2021-09-16 22:53 ` Darrick J. Wong
2021-09-17 2:31 ` Amir Goldstein
2021-09-17 16:00 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=163174935747.380880.7635671692624086987.stgit@magnolia \
--to=djwong@kernel.org \
--cc=darrick.wong@oracle.com \
--cc=fstests@vger.kernel.org \
--cc=guan@eryu.me \
--cc=guaneryu@gmail.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--subject='Re: [PATCHSET v3 0/9] fstests: document all test groups' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).