From: Allison Henderson <allison.henderson@oracle.com>
To: "Darrick J. Wong" <djwong@kernel.org>, sandeen@sandeen.net
Cc: Brian Foster <bfoster@redhat.com>, Christoph Hellwig <hch@lst.de>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/7] xfs_admin: clean up string quoting
Date: Tue, 23 Feb 2021 13:18:15 -0700 [thread overview]
Message-ID: <17680305-b691-970c-726d-ca18a8ac3199@oracle.com> (raw)
In-Reply-To: <161404922408.425352.8871380789546968040.stgit@magnolia>
On 2/22/21 8:00 PM, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Clean up the string quoting in this script so that we don't trip over
> users feeding us arguments like "/dev/sd ha ha ha lol".
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> Reviewed-by: Brian Foster <bfoster@redhat.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Looks ok
Reviewed-by: Allison Henderson <allison.henderson@oracle.com>
> ---
> db/xfs_admin.sh | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
> diff --git a/db/xfs_admin.sh b/db/xfs_admin.sh
> index bd325da2..71a9aa98 100755
> --- a/db/xfs_admin.sh
> +++ b/db/xfs_admin.sh
> @@ -43,7 +43,7 @@ case $# in
>
> if [ -n "$DB_OPTS" ]
> then
> - eval xfs_db -x -p xfs_admin $DB_OPTS $1
> + eval xfs_db -x -p xfs_admin $DB_OPTS "$1"
> status=$?
> fi
> if [ -n "$REPAIR_OPTS" ]
> @@ -53,7 +53,7 @@ case $# in
> # running xfs_admin.
> # Ideally, we need to improve the output behaviour
> # of repair for this purpose (say a "quiet" mode).
> - eval xfs_repair $REPAIR_OPTS $1 2> /dev/null
> + eval xfs_repair $REPAIR_OPTS "$1" 2> /dev/null
> status=`expr $? + $status`
> if [ $status -ne 0 ]
> then
>
next prev parent reply other threads:[~2021-02-23 20:19 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 3:00 [PATCHSET v6 0/7] xfsprogs: add the ability to flag a fs for repair Darrick J. Wong
2021-02-23 3:00 ` [PATCH 1/7] xfs_admin: clean up string quoting Darrick J. Wong
2021-02-23 20:18 ` Allison Henderson [this message]
2021-02-23 3:00 ` [PATCH 2/7] xfs_admin: support filesystems with realtime devices Darrick J. Wong
2021-02-23 20:18 ` Allison Henderson
2021-02-23 3:00 ` [PATCH 3/7] xfs_db: report the needsrepair flag in check and version commands Darrick J. Wong
2021-02-23 20:18 ` Allison Henderson
2021-02-25 8:11 ` Christoph Hellwig
2021-02-23 3:00 ` [PATCH 4/7] xfs_db: don't allow label/uuid setting if the needsrepair flag is set Darrick J. Wong
2021-02-23 20:18 ` Allison Henderson
2021-02-25 8:13 ` Christoph Hellwig
2021-02-23 3:00 ` [PATCH 5/7] xfs_repair: fix unmount error message to have a newline Darrick J. Wong
2021-02-23 20:18 ` Allison Henderson
2021-02-23 3:00 ` [PATCH 6/7] xfs_repair: clear quota CHKD flags on the incore superblock too Darrick J. Wong
2021-02-23 20:18 ` Allison Henderson
2021-02-23 3:00 ` [PATCH 7/7] xfs_repair: clear the needsrepair flag Darrick J. Wong
2021-02-23 20:18 ` Allison Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17680305-b691-970c-726d-ca18a8ac3199@oracle.com \
--to=allison.henderson@oracle.com \
--cc=bfoster@redhat.com \
--cc=chaitanya.kulkarni@wdc.com \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).