From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH v2] xfs: store rmapbt block count in the AGF
Date: Thu, 4 Aug 2016 08:50:42 -0700 [thread overview]
Message-ID: <20160804155042.GW8590@birch.djwong.org> (raw)
In-Reply-To: <20160804154439.GA15656@infradead.org>
On Thu, Aug 04, 2016 at 08:44:39AM -0700, Christoph Hellwig wrote:
> On Wed, Aug 03, 2016 at 02:46:13PM -0700, Darrick J. Wong wrote:
> > Track the number of blocks used for the rmapbt in the AGF. When we
> > get to the AG reservation code we need this counter to quickly
> > make our reservation during mount.
> >
> > v2: Actually include growfs support.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > ---
> > fs/xfs/libxfs/xfs_alloc.c | 1 +
> > fs/xfs/libxfs/xfs_format.h | 11 ++++++++---
> > fs/xfs/libxfs/xfs_rmap_btree.c | 6 ++++++
> > fs/xfs/xfs_fsops.c | 1 +
> > 4 files changed, 16 insertions(+), 3 deletions(-)
> >
> > diff --git a/fs/xfs/libxfs/xfs_alloc.c b/fs/xfs/libxfs/xfs_alloc.c
> > index 776ae2f..af1a72e 100644
> > --- a/fs/xfs/libxfs/xfs_alloc.c
> > +++ b/fs/xfs/libxfs/xfs_alloc.c
> > @@ -2264,6 +2264,7 @@ xfs_alloc_log_agf(
> > offsetof(xfs_agf_t, agf_longest),
> > offsetof(xfs_agf_t, agf_btreeblks),
> > offsetof(xfs_agf_t, agf_uuid),
> > + offsetof(xfs_agf_t, agf_rmap_blocks),
> > sizeof(xfs_agf_t)
> > };
> >
> > diff --git a/fs/xfs/libxfs/xfs_format.h b/fs/xfs/libxfs/xfs_format.h
> > index f814d42..e6a8bea 100644
> > --- a/fs/xfs/libxfs/xfs_format.h
> > +++ b/fs/xfs/libxfs/xfs_format.h
> > @@ -640,12 +640,15 @@ typedef struct xfs_agf {
> > __be32 agf_btreeblks; /* # of blocks held in AGF btrees */
> > uuid_t agf_uuid; /* uuid of filesystem */
> >
> > + __be32 agf_rmap_blocks; /* rmapbt blocks used */
> > + __be32 agf_padding; /* padding */
>
> Now _spare? It could easily be used by the next new field.
The reflink patches will (almost immediately) consume agf_padding
and the next spare for refcount_{root,level,blocks}.
--D
> Otherwise this looks fine to me:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2016-08-04 15:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 21:46 [PATCH v2] xfs: store rmapbt block count in the AGF Darrick J. Wong
2016-08-04 15:44 ` Christoph Hellwig
2016-08-04 15:50 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160804155042.GW8590@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).