From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: linux-pm@vger.kernel.org, xfs <linux-xfs@vger.kernel.org>
Subject: [PATCH] xfs: don't let suspend freeze the buffer workqueue
Date: Mon, 27 Mar 2017 13:46:11 -0700 [thread overview]
Message-ID: <20170327204611.GA4864@birch.djwong.org> (raw)
Suspend has this annoying behavior in XFS where it freezes workqueues in
some arbitrary order. This is a problem because the sync call can cause
an AIL push, which may have to perform a RMW cycle on an inode cluster
buffer if that buffer has been reclaimed. When this happens, the AIL
issues a buffer read for which the io completion ends up on the xfs_buf
workqueue. If /that/ workqueue has already been frozen, the suspend
will timeout because we froze the workqueues in the wrong order.
It seems suspicious to be freezing IO helper threads[1], so let's just
not do that anymore. Prior to this patch, 4.10 fails to suspend on my
laptop about 80% of the time; afterwards, it works every time. I've not
done much suspend-and-crash testing on it though.
[1] https://lwn.net/Articles/705269/
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
fs/xfs/xfs_super.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
index 7af5ca9..216ab89 100644
--- a/fs/xfs/xfs_super.c
+++ b/fs/xfs/xfs_super.c
@@ -842,7 +842,7 @@ xfs_init_mount_workqueues(
struct xfs_mount *mp)
{
mp->m_buf_workqueue = alloc_workqueue("xfs-buf/%s",
- WQ_MEM_RECLAIM|WQ_FREEZABLE, 1, mp->m_fsname);
+ WQ_MEM_RECLAIM, 1, mp->m_fsname);
if (!mp->m_buf_workqueue)
goto out;
next reply other threads:[~2017-03-27 20:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 20:46 Darrick J. Wong [this message]
2017-03-27 22:40 ` [PATCH] xfs: don't let suspend freeze the buffer workqueue Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170327204611.GA4864@birch.djwong.org \
--to=darrick.wong@oracle.com \
--cc=linux-pm@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).