From: Jan Kara <jack@suse.cz>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org, jack@suse.cz
Subject: Re: [PATCH 1/2] iomap: return VM_FAULT_* codes from iomap_page_mkwrite
Date: Wed, 30 Aug 2017 10:50:07 +0200 [thread overview]
Message-ID: <20170830085007.GA28354@quack2.suse.cz> (raw)
In-Reply-To: <20170829162613.27270-2-hch@lst.de>
On Tue 29-08-17 18:26:12, Christoph Hellwig wrote:
> All callers will need the VM_FAULT_* flags, so convert in the helper.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Looks good. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/iomap.c | 4 ++--
> fs/xfs/xfs_file.c | 1 -
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/fs/iomap.c b/fs/iomap.c
> index 59cc98ad7577..8554a8d75281 100644
> --- a/fs/iomap.c
> +++ b/fs/iomap.c
> @@ -477,10 +477,10 @@ int iomap_page_mkwrite(struct vm_fault *vmf, const struct iomap_ops *ops)
>
> set_page_dirty(page);
> wait_for_stable_page(page);
> - return 0;
> + return VM_FAULT_LOCKED;
> out_unlock:
> unlock_page(page);
> - return ret;
> + return block_page_mkwrite_return(ret);
> }
> EXPORT_SYMBOL_GPL(iomap_page_mkwrite);
>
> diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c
> index c4893e226fd8..8b0181c6d2a6 100644
> --- a/fs/xfs/xfs_file.c
> +++ b/fs/xfs/xfs_file.c
> @@ -1035,7 +1035,6 @@ xfs_filemap_page_mkwrite(
> ret = dax_iomap_fault(vmf, PE_SIZE_PTE, &xfs_iomap_ops);
> } else {
> ret = iomap_page_mkwrite(vmf, &xfs_iomap_ops);
> - ret = block_page_mkwrite_return(ret);
> }
>
> xfs_iunlock(XFS_I(inode), XFS_MMAPLOCK_SHARED);
> --
> 2.11.0
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
next prev parent reply other threads:[~2017-08-30 8:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-29 16:26 cleanup the page fault path V2 Christoph Hellwig
2017-08-29 16:26 ` [PATCH 1/2] iomap: return VM_FAULT_* codes from iomap_page_mkwrite Christoph Hellwig
2017-08-30 8:50 ` Jan Kara [this message]
2017-08-29 16:26 ` [PATCH 2/2] xfs: consolidate the various page fault handlers Christoph Hellwig
2017-08-29 18:48 ` Darrick J. Wong
2017-08-30 9:34 ` Jan Kara
2017-08-30 16:09 ` cleanup the page fault path V2 Darrick J. Wong
-- strict thread matches above, loose matches on Subject: below --
2017-08-28 6:36 cleanup the page faul path Christoph Hellwig
2017-08-28 6:36 ` [PATCH 1/2] iomap: return VM_FAULT_* codes from iomap_page_mkwrite Christoph Hellwig
2017-08-28 16:33 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170830085007.GA28354@quack2.suse.cz \
--to=jack@suse.cz \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).