From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com ([209.132.183.28]:37953 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727781AbeKJAMa (ORCPT ); Fri, 9 Nov 2018 19:12:30 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 1EC5E3002E00 for ; Fri, 9 Nov 2018 14:31:40 +0000 (UTC) From: Jan Tulak Subject: [PATCH 02/24] xfsdump: do not split function call with ifdef Date: Fri, 9 Nov 2018 15:29:42 +0100 Message-Id: <20181109143004.24963-3-jtulak@redhat.com> In-Reply-To: <20181109143004.24963-1-jtulak@redhat.com> References: <20181109143004.24963-1-jtulak@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: linux-xfs@vger.kernel.org Cc: Jan Tulak In two files in xfsdump, a function call is split in half by an ifdef macro to conditionally pick an argument at compile time. This causes the code to be a bit less obvious and some analysis tools have trouble with understanding it. So, instead of splitting the function in half, move the whole function call into each of the ifdef macros. Signed-off-by: Jan Tulak --- common/drive_minrmt.c | 3 ++- common/main.c | 8 ++++++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/common/drive_minrmt.c b/common/drive_minrmt.c index 59a40a7..04fed3e 100644 --- a/common/drive_minrmt.c +++ b/common/drive_minrmt.c @@ -2585,11 +2585,12 @@ read_label( drive_t *drivep ) if (( nread == 0 ) /* takes care of sun */ || /* now handle SGI */ (nread < 0 && saved_errno == ENOSPC )) { - mlog( MLOG_NORMAL | MLOG_DRIVE, #ifdef DUMP + mlog( MLOG_NORMAL | MLOG_DRIVE, _("encountered EOD : assuming blank media\n") ); #endif #ifdef RESTORE + mlog( MLOG_NORMAL | MLOG_DRIVE, _("encountered EOD : end of data\n") ); #endif ( void )rewind_and_verify( drivep ); diff --git a/common/main.c b/common/main.c index b3605d1..0c23eb4 100644 --- a/common/main.c +++ b/common/main.c @@ -581,12 +581,14 @@ main( int argc, char *argv[] ) sigaction( SIGTERM, &sa, NULL ); sigaction( SIGQUIT, &sa, NULL ); +#ifdef DUMP ok = drive_init2( argc, argv, -#ifdef DUMP gwhdrtemplatep ); #endif /* DUMP */ #ifdef RESTORE + ok = drive_init2( argc, + argv, ( global_hdr_t * )0 ); #endif /* RESTORE */ if ( ! ok ) { @@ -629,12 +631,14 @@ main( int argc, char *argv[] ) * time-consuming chore. drive_init3 will synchronize with each slave. */ if ( ! init_error ) { +#ifdef DUMP ok = drive_init2( argc, argv, -#ifdef DUMP gwhdrtemplatep ); #endif /* DUMP */ #ifdef RESTORE + ok = drive_init2( argc, + argv, ( global_hdr_t * )0 ); #endif /* RESTORE */ if ( ! ok ) { -- 2.19.1