From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org ([198.137.202.133]:35482 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727398AbeKPTE6 (ORCPT ); Fri, 16 Nov 2018 14:04:58 -0500 Date: Fri, 16 Nov 2018 00:53:33 -0800 From: Christoph Hellwig Subject: Re: [PATCH] block: fix 32 bit overflow in __blkdev_issue_discard() Message-ID: <20181116085333.GA4544@infradead.org> References: <20181113214337.20581-1-david@fromorbit.com> <10a8dd78-7c00-8593-9f4e-b20eb1161b92@kernel.dk> <20181115010651.GD32603@ming.t460p> <20181115012201.GX19305@dastard> <20181115031035.GE32603@ming.t460p> <20181115221337.GY19305@dastard> <20181115222419.GV4235@magnolia> <20181116040457.GA19305@dastard> <20181116083232.GA9023@infradead.org> <20181116084658.GT23828@vader> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181116084658.GT23828@vader> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Omar Sandoval Cc: Christoph Hellwig , Dave Chinner , "Darrick J. Wong" , Ming Lei , Jens Axboe , linux-xfs@vger.kernel.org, linux-block@vger.kernel.org On Fri, Nov 16, 2018 at 12:46:58AM -0800, Omar Sandoval wrote: > > > generic/349 [not run] scsi_debug module not found > > > generic/350 [not run] scsi_debug module not found > > > generic/351 [not run] scsi_debug module not found > > > > Same here, btw. Any test that requires modules is a rather bad idea. > > I'll plug my vm.py script that supports running a kernel build with > modules without installing them into the VM (by mounting the modules > over 9p): https://github.com/osandov/osandov-linux#vm-setup All nice and good, but avoiding complexity is even better :) Especially as there should be no reason to only allowing to configure something at module load time in this century.