From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp2120.oracle.com ([141.146.126.78]:41404 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726382AbeK2KiW (ORCPT ); Thu, 29 Nov 2018 05:38:22 -0500 Date: Wed, 28 Nov 2018 15:34:59 -0800 From: "Darrick J. Wong" Subject: Re: [PATCH 1/6] xfs_io.8: rearrange command listings by section Message-ID: <20181128233459.GD8131@magnolia> References: <154181071499.3727.3910572718199592407.stgit@magnolia> <154181072098.3727.12783001969841425328.stgit@magnolia> <8c568cb2-4931-288c-0be3-68bd5caef634@sandeen.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8c568cb2-4931-288c-0be3-68bd5caef634@sandeen.net> Sender: linux-xfs-owner@vger.kernel.org List-ID: List-Id: xfs To: Eric Sandeen Cc: linux-xfs@vger.kernel.org On Wed, Nov 28, 2018 at 04:39:47PM -0600, Eric Sandeen wrote: > On 11/9/18 6:45 PM, Darrick J. Wong wrote: > > From: Darrick J. Wong > > > > Most of the commands listed under "OTHER COMMANDS" apply to files or > > filesystems. Create two new sections for that and populate them > > appropriately. > > > > Here's what moves: > > > > fsmap: moves from file io commands to filesystem commands > > utimes: moves from file io commands to file commands > > > >>From the OTHER COMMANDS section: > > > > lsattr/chattr: moves to file commands > > flink: moves to file commands > > stat/statx: moves to file commands > > lsproj/chproj: moves to file commands > > parent: moves to file commands > > [gs]et_encpolicy: moves to file io commands > > freeze/thaw: move to filesystem commands > > inject: move to filesystem commands > > resblks: move to filesystem commands > > shutdown: move to filesystem commands > > statfs: move to filesystem commands > > label: move to filesystem commands > > Thank you for getting this better organized. Of course, I have > some questions. :) > > What does "FILE COMMANDS" vs. "FILE I/O COMMANDS" mean, exactly? > I ask because for example bmap & fiemap are still under FILE IO but > they... really don't do file IO. What's your intended distinction > with these new sections? Admittedly, it's been a looong time since I wrote this patch. Um... I think my intent was for FILE COMMANDS to pertain to file attributes, whereas FILE I/O COMMANDS would pertain to reading, writing, encoding, mapping, and otherwise messing with the contents of a file. --D > > Thanks, > -Eric