From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>,
hch@infradead.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org, Damien.LeMoal@wdc.com,
Christoph Hellwig <hch@lst.de>,
agruenba@redhat.com
Subject: Re: [PATCH 1/5] xfs: use a struct iomap in xfs_writepage_ctx
Date: Tue, 6 Aug 2019 07:34:25 +0200 [thread overview]
Message-ID: <20190806053425.GG13409@lst.de> (raw)
In-Reply-To: <20190805123826.6bv7jhcnw5ecnol7@orion.maiolino.org>
On Mon, Aug 05, 2019 at 02:38:26PM +0200, Carlos Maiolino wrote:
> > - * Attempt to allocate whatever delalloc extent currently backs
> > - * offset_fsb and put the result into wpc->imap. Allocate in a loop
> > - * because it may take several attempts to allocate real blocks for a
> > - * contiguous delalloc extent if free space is sufficiently fragmented.
> > + * Attempt to allocate whatever delalloc extent currently backs offset
> > + * and put the result into wpc->imap. Allocate in a loop because it may
> ^^^^
> And put the result into wpc->iomap?
Yes. Darrick, can you fix this up when applying?
next prev parent reply other threads:[~2019-08-06 5:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-30 1:18 [PATCH v4 0/5] xfs: use the iomap writeback code Darrick J. Wong
2019-07-30 1:18 ` [PATCH 1/5] xfs: use a struct iomap in xfs_writepage_ctx Darrick J. Wong
2019-08-05 12:38 ` Carlos Maiolino
2019-08-06 5:34 ` Christoph Hellwig [this message]
2019-07-30 1:18 ` [PATCH 2/5] xfs: turn io_append_trans into an io_private void pointer Darrick J. Wong
2019-08-05 12:40 ` Carlos Maiolino
2019-07-30 1:19 ` [PATCH 3/5] xfs: remove the fork fields in the writepage_ctx and ioend Darrick J. Wong
2019-08-05 12:54 ` Carlos Maiolino
2019-07-30 1:19 ` [PATCH 4/5] xfs: convert the xfs writeback code to iomap writeback Darrick J. Wong
2019-08-05 12:52 ` Carlos Maiolino
2019-07-30 1:19 ` [PATCH 5/5] iomap: move struct iomap_page out of iomap.h Darrick J. Wong
2019-08-05 12:53 ` Carlos Maiolino
2019-09-03 12:57 xfs: use the iomap writeback code v2 Christoph Hellwig
2019-09-03 12:57 ` [PATCH 1/5] xfs: use a struct iomap in xfs_writepage_ctx Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806053425.GG13409@lst.de \
--to=hch@lst.de \
--cc=Damien.LeMoal@wdc.com \
--cc=agruenba@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).