From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0649FC3A59F for ; Mon, 26 Aug 2019 23:22:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CC0BF206B7 for ; Mon, 26 Aug 2019 23:22:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726944AbfHZXWH (ORCPT ); Mon, 26 Aug 2019 19:22:07 -0400 Received: from mail105.syd.optusnet.com.au ([211.29.132.249]:43906 "EHLO mail105.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726020AbfHZXWH (ORCPT ); Mon, 26 Aug 2019 19:22:07 -0400 Received: from dread.disaster.area (pa49-181-255-194.pa.nsw.optusnet.com.au [49.181.255.194]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id 7C00812E9AA; Tue, 27 Aug 2019 09:22:05 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92) (envelope-from ) id 1i2OJH-0000mC-VU; Tue, 27 Aug 2019 09:22:03 +1000 Date: Tue, 27 Aug 2019 09:22:03 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH 2/5] xfs: remove unnecessary int returns from deferred rmap functions Message-ID: <20190826232203.GR1119@dread.disaster.area> References: <156685615360.2853674.5160169873645196259.stgit@magnolia> <156685616759.2853674.14113052736055839178.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <156685616759.2853674.14113052736055839178.stgit@magnolia> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.2 cv=P6RKvmIu c=1 sm=1 tr=0 a=YO9NNpcXwc8z/SaoS+iAiA==:117 a=YO9NNpcXwc8z/SaoS+iAiA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=FmdZ9Uzk2mMA:10 a=yPCof4ZbAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=5aZa_9Cg802i1HTZ-X0A:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Mon, Aug 26, 2019 at 02:49:27PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > Remove the return value from the functions that schedule deferred rmap > operations since they never fail and do not return status. > > Signed-off-by: Darrick J. Wong > --- > fs/xfs/libxfs/xfs_bmap.c | 36 ++++++++++++------------------------ > fs/xfs/libxfs/xfs_refcount.c | 9 +++------ > fs/xfs/libxfs/xfs_rmap.c | 33 ++++++++++++++++----------------- > fs/xfs/libxfs/xfs_rmap.h | 10 +++++----- > 4 files changed, 36 insertions(+), 52 deletions(-) Amazing how much gunk a bit of unnecessary error checking adds... Looks good. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com