From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65E85C3A5A3 for ; Tue, 27 Aug 2019 10:04:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3CDF1217F5 for ; Tue, 27 Aug 2019 10:04:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727784AbfH0KET (ORCPT ); Tue, 27 Aug 2019 06:04:19 -0400 Received: from mx2.suse.de ([195.135.220.15]:43072 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725805AbfH0KET (ORCPT ); Tue, 27 Aug 2019 06:04:19 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 1DD75AE91; Tue, 27 Aug 2019 10:04:18 +0000 (UTC) Date: Tue, 27 Aug 2019 12:04:16 +0200 From: Petr Vorel To: Murphy Zhou Cc: Yang Xu , chrubis@suse.cz, ltp@lists.linux.it, linux-xfs@vger.kernel.org, Clemens Famulla-Conrad Subject: Re: [LTP] [PATCH v7 3/3] syscalls/copy_file_range02: increase coverage and remove EXDEV test Message-ID: <20190827100416.GB17923@dell5510> Reply-To: Petr Vorel References: <20190730110555.GB7528@rei.lan> <1564569629-2358-1-git-send-email-xuyang2018.jy@cn.fujitsu.com> <1564569629-2358-3-git-send-email-xuyang2018.jy@cn.fujitsu.com> <20190805065832.ti6vpoviykfaxcj7@XZHOUW.usersys.redhat.com> <5D47D6B9.9090306@cn.fujitsu.com> <20190805102211.pvyufepn6xywi7vm@XZHOUW.usersys.redhat.com> <20190806162703.GA1333@dell5510> <20190807101742.mt6tgowsh4xw5hyt@XZHOUW.usersys.redhat.com> <5D4B92EF.4090800@cn.fujitsu.com> <20190808035730.3kzors4trok6amtr@XZHOUW.usersys.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190808035730.3kzors4trok6amtr@XZHOUW.usersys.redhat.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org Hi Murphy, > On Thu, Aug 08, 2019 at 11:11:43AM +0800, Yang Xu wrote: > > on 2019/08/07 18:17, Murphy Zhou wrote: > > > And I have a question about LTP itself. > > > If we run the testcase directly like: > > > ./testcases/kernel/syscalls/copy_file_range/copy_file_range02 > > > to test all_filesystems, for every filesystem, we mkfs and mount it in > > > .mntpoint, but we do not chdir to .mntpoint. So we are running tests in > > > the same tmpdir, fs type of which does not change while looping > > > all_filesystems. Only the .mntpoint in tmpdir has different fs type in > > > each loop. > > > Now we are using this to test cross-device copy in copy_file_range01.c, > > > but in copy_file_range02.c, we are not using .mntpint at all, all the > > > tests in the all_filesystems loop are running in the same tmpdir. In other > > > words, we are NOT testing all filesystems. > > > Is this expected? > > I removed the mnted test for cross-device copy_file_range in copy_file_range02.c. > > And I ignore the non-used mntpoint. IMO, we can directly use the FILE_MNTED to test EFBIG on all filesystems, > If mntpoint is not used, it makes absolutely NO sense to test all_filesystems. Thanks for pointing this out. I was blind when reviewing this patchset. At least this has been fixed. > Because in the all_filesystems loop, various supported filesystems are > created and mounted in mntpoint. > And the copy_file_range tests happens outside of mntpoint. It just repeats > the same test several times in the same tmpdir, fs type of which depends > on /tmp configuration. > When the log prints "testing ext2", it's not the truth. > EFBIG is another issue. Yep, we still need to think about different errnos, which depend on LTP policy being defined [1]. > Thanks, > Murphy Kind regards, Petr [1] https://patchwork.ozlabs.org/patch/1143438/