From: Dave Chinner <david@fromorbit.com>
To: kaixuxia <xiakaixu1987@gmail.com>
Cc: Eric Sandeen <sandeen@sandeen.net>,
linux-xfs@vger.kernel.org,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Brian Foster <bfoster@redhat.com>,
newtongao@tencent.com, jasperwang@tencent.com
Subject: Re: [PATCH v3] xfs: Fix ABBA deadlock between AGI and AGF when performing rename() with RENAME_WHITEOUT flag
Date: Thu, 29 Aug 2019 15:35:20 +1000 [thread overview]
Message-ID: <20190829053520.GM1119@dread.disaster.area> (raw)
In-Reply-To: <ff809542-5b25-d204-47e8-a75bd3e0320b@gmail.com>
On Thu, Aug 29, 2019 at 11:20:37AM +0800, kaixuxia wrote:
>
>
> On 2019/8/29 11:04, Eric Sandeen wrote:
> > On 8/28/19 8:27 PM, kaixuxia wrote:
> >> ping...
> >> Because there isn't this patch in the latest xfs-for-next branch
> >> update...
> >
> > 1) V3 appears to have no changes from V2. Why was V3 sent?
> >
> The V3 subject has been changed to distinguish from another droplink
> deadlock patch that will be sent soon. This V3 patch aim to fix the
> rename whiteout deadlock.
And now the subject line for the patch is far too long. it is
almost twice as long as the old one, doesn't fit on one line without
wrapping, and really doesn't tell us anything much extra. If you
really must say it's a whiteout issue, then:
xfs: Fix deadlock between AGI and AGF with RENAME_WHITEOUT
is sufficient. It's a summary - the above contains the problem, the
objects involved and the operation that needs to be fixed. Nothing
more is necessary. It needs to fit into ~60 characters so that
when you run git log --one-line the output can be pasted directly
into email without wrapping....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
prev parent reply other threads:[~2019-08-29 5:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 2:54 [PATCH v3] xfs: Fix ABBA deadlock between AGI and AGF when performing rename() with RENAME_WHITEOUT flag kaixuxia
2019-08-29 1:27 ` kaixuxia
2019-08-29 3:04 ` Eric Sandeen
2019-08-29 3:20 ` kaixuxia
2019-08-29 3:22 ` Eric Sandeen
2019-08-29 5:35 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829053520.GM1119@dread.disaster.area \
--to=david@fromorbit.com \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=jasperwang@tencent.com \
--cc=linux-xfs@vger.kernel.org \
--cc=newtongao@tencent.com \
--cc=sandeen@sandeen.net \
--cc=xiakaixu1987@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).