From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4364EC3A5A7 for ; Thu, 29 Aug 2019 08:18:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0BF5E2189D for ; Thu, 29 Aug 2019 08:18:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="MAppl29J" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726634AbfH2ISY (ORCPT ); Thu, 29 Aug 2019 04:18:24 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:57998 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726223AbfH2ISX (ORCPT ); Thu, 29 Aug 2019 04:18:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=G6iErwNsEr7x92GVAgMbsogUZfa6zBfukCgxzkuEc74=; b=MAppl29JD0vivm1kvE+UdhEIR E9jkVUN1s6Lg7AOGUqpoM9P/yiqTQV027eEINHCRbrLayN0D+3L15RjWBsjjENjWV3S4EfQTUGJLS PJtgvjZOCAwm67sygZO9HvKyGFVbZJd1+emL1Vt8BwXNmn/wjans4EI0mAaChy6wGQA2E683R2/iE mC3PV6iOhsluAL7Ls3ubCEXd3+s18WWNjKXuxn4QPbOGhKifByYLIzzJGKdROOJPQPNFIg+0EF3qe mXwhIHkrlkdRx5MaVgddsgiWtv46/q7EAFQIbAv3c1J4wGoggbQdU6xidMZxx9XYadqhNSdNrjfJ3 XtRI+AbCg==; Received: from hch by bombadil.infradead.org with local (Exim 4.92 #3 (Red Hat Linux)) id 1i3FLV-0004nX-UP; Thu, 29 Aug 2019 07:59:53 +0000 Date: Thu, 29 Aug 2019 00:59:53 -0700 From: Christoph Hellwig To: Dave Chinner Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH 1/5] xfs: move xfs_dir2_addname() Message-ID: <20190829075953.GA18195@infradead.org> References: <20190829063042.22902-1-david@fromorbit.com> <20190829063042.22902-2-david@fromorbit.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190829063042.22902-2-david@fromorbit.com> User-Agent: Mutt/1.11.4 (2019-03-13) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Thu, Aug 29, 2019 at 04:30:38PM +1000, Dave Chinner wrote: > From: Dave Chinner > > This gets rid of the need for a forward declaration of the static > function xfs_dir2_addname_int() and readies the code for factoring > of xfs_dir2_addname_int(). > > Signed-off-by: Dave Chinner Looks good, Reviewed-by: Christoph Hellwig