From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/5] xfs: factor free block index lookup from xfs_dir2_node_addname_int()
Date: Thu, 29 Aug 2019 01:10:13 -0700 [thread overview]
Message-ID: <20190829081013.GC18195@infradead.org> (raw)
In-Reply-To: <20190829063042.22902-4-david@fromorbit.com>
On Thu, Aug 29, 2019 at 04:30:40PM +1000, Dave Chinner wrote:
> + /*
> + * Now we know if we must allocate blocks, so if we are checking whether
> + * we can insert without allocation then we can return now.
> + */
> + if (args->op_flags & XFS_DA_OP_JUSTCHECK) {
> + if (dbno != -1)
> + return 0;
> + return -ENOSPC;
> + }
Nit: I'd invert the check to rturn -ENOSPC in the branch if dbno is
-1 to make the flow a littler easier.
Otherwise this looks great and makes the code much easier to read:
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2019-08-29 8:18 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-29 6:30 [PATCH V2 0/5] xfs: speed up large directory modifications Dave Chinner
2019-08-29 6:30 ` [PATCH 1/5] xfs: move xfs_dir2_addname() Dave Chinner
2019-08-29 7:59 ` Christoph Hellwig
2019-08-29 6:30 ` [PATCH 2/5] xfs: factor data block addition from xfs_dir2_node_addname_int() Dave Chinner
2019-08-29 8:05 ` Christoph Hellwig
2019-08-29 8:34 ` Dave Chinner
2019-08-29 6:30 ` [PATCH 3/5] xfs: factor free block index lookup " Dave Chinner
2019-08-29 8:10 ` Christoph Hellwig [this message]
2019-08-29 8:35 ` Dave Chinner
2019-08-29 6:30 ` [PATCH 4/5] xfs: speed up directory bestfree block scanning Dave Chinner
2019-08-29 8:18 ` Christoph Hellwig
2019-08-29 8:45 ` Dave Chinner
2019-08-29 8:47 ` Christoph Hellwig
2019-08-29 8:55 ` Dave Chinner
2019-08-29 8:25 ` Christoph Hellwig
2019-08-29 9:31 ` Dave Chinner
2019-08-29 9:33 ` Christoph Hellwig
2019-08-29 6:30 ` [PATCH 5/5] xfs: reverse search directory freespace indexes Dave Chinner
2019-08-29 8:23 ` Christoph Hellwig
2019-08-29 9:14 ` Dave Chinner
-- strict thread matches above, loose matches on Subject: below --
2019-08-29 10:47 [PATCH v3 0/5] xfs: speed up large directory modifications Dave Chinner
2019-08-29 10:47 ` [PATCH 3/5] xfs: factor free block index lookup from xfs_dir2_node_addname_int() Dave Chinner
2019-08-29 21:07 ` Darrick J. Wong
2018-10-24 22:57 [PATCH 0/5] xfs: speed up large directory modifications Dave Chinner
2018-10-24 22:57 ` [PATCH 3/5] xfs: factor free block index lookup from xfs_dir2_node_addname_int() Dave Chinner
2018-10-26 9:48 ` Christoph Hellwig
2018-10-26 10:49 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829081013.GC18195@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).