From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@redhat.com>
Cc: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Re: [PATCH] xfs: log proper length of btree block in scrub/repair
Date: Thu, 29 Aug 2019 14:31:50 -0700 [thread overview]
Message-ID: <20190829213150.GS5354@magnolia> (raw)
In-Reply-To: <f66b01bb-b4ce-8713-c3db-fbbd39703737@redhat.com>
On Tue, Aug 27, 2019 at 02:17:36PM -0500, Eric Sandeen wrote:
> xfs_trans_log_buf() takes a final argument of the last byte to
> log in the buffer; b_length is in basic blocks, so this isn't
> the correct last byte. Fix it.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
>
> just found by inspection/pattern matching, not tested TBH...
>
> diff --git a/fs/xfs/scrub/repair.c b/fs/xfs/scrub/repair.c
> index 4cfeec57fb05..7bcc755beb40 100644
> --- a/fs/xfs/scrub/repair.c
> +++ b/fs/xfs/scrub/repair.c
> @@ -351,7 +351,7 @@ xrep_init_btblock(
> xfs_buf_zero(bp, 0, BBTOB(bp->b_length));
> xfs_btree_init_block(mp, bp, btnum, 0, 0, sc->sa.agno);
> xfs_trans_buf_set_type(tp, bp, XFS_BLFT_BTREE_BUF);
> - xfs_trans_log_buf(tp, bp, 0, bp->b_length);
> + xfs_trans_log_buf(tp, bp, 0, BBTOB(bp->b_length) - 1);
> bp->b_ops = ops;
> *bpp = bp;
>
>
prev parent reply other threads:[~2019-08-29 21:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-27 19:17 [PATCH] xfs: log proper length of btree block in scrub/repair Eric Sandeen
2019-08-27 23:29 ` Dave Chinner
2019-08-29 8:26 ` Christoph Hellwig
2019-08-30 14:36 ` Eric Sandeen
2019-08-29 21:31 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190829213150.GS5354@magnolia \
--to=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).