From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3BC3C3A5A3 for ; Fri, 30 Aug 2019 05:43:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8A18321721 for ; Fri, 30 Aug 2019 05:43:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726716AbfH3Fne (ORCPT ); Fri, 30 Aug 2019 01:43:34 -0400 Received: from mail105.syd.optusnet.com.au ([211.29.132.249]:40681 "EHLO mail105.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726023AbfH3Fne (ORCPT ); Fri, 30 Aug 2019 01:43:34 -0400 Received: from dread.disaster.area (pa49-181-255-194.pa.nsw.optusnet.com.au [49.181.255.194]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id 29DD6362AC0; Fri, 30 Aug 2019 15:43:32 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92) (envelope-from ) id 1i3Zh4-0003r2-Dr; Fri, 30 Aug 2019 15:43:30 +1000 Date: Fri, 30 Aug 2019 15:43:30 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org Subject: Re: [PATCH 03/12] libfrog: try the v4 fs geometry ioctl after failing the v5 ioctl Message-ID: <20190830054330.GE1119@dread.disaster.area> References: <156633307176.1215978.17394956977918540525.stgit@magnolia> <156633309007.1215978.12240756059931527276.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <156633309007.1215978.12240756059931527276.stgit@magnolia> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.2 cv=P6RKvmIu c=1 sm=1 tr=0 a=YO9NNpcXwc8z/SaoS+iAiA==:117 a=YO9NNpcXwc8z/SaoS+iAiA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=FmdZ9Uzk2mMA:10 a=yPCof4ZbAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=nFplAslS4ZV_g51VT9kA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Aug 20, 2019 at 01:31:30PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > If a v5 fs geometry query fails, try the v4 interface before falling > back to the v1 interface. > > Signed-off-by: Darrick J. Wong > --- > libfrog/fsgeom.c | 4 ++++ > 1 file changed, 4 insertions(+) looks good to me. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com