From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58F14C3A5A9 for ; Wed, 4 Sep 2019 21:22:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3C27421726 for ; Wed, 4 Sep 2019 21:22:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727900AbfIDVWS (ORCPT ); Wed, 4 Sep 2019 17:22:18 -0400 Received: from mail105.syd.optusnet.com.au ([211.29.132.249]:44444 "EHLO mail105.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727809AbfIDVWS (ORCPT ); Wed, 4 Sep 2019 17:22:18 -0400 Received: from dread.disaster.area (pa49-181-255-194.pa.nsw.optusnet.com.au [49.181.255.194]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id 71D1F3628E7; Thu, 5 Sep 2019 07:22:16 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92) (envelope-from ) id 1i5cjH-0007Wd-Am; Thu, 05 Sep 2019 07:22:15 +1000 Date: Thu, 5 Sep 2019 07:22:15 +1000 From: Dave Chinner To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH 4/7] xfs: factor callbacks out of xlog_state_do_callback() Message-ID: <20190904212215.GG1119@dread.disaster.area> References: <20190904042451.9314-1-david@fromorbit.com> <20190904042451.9314-5-david@fromorbit.com> <20190904063240.GA24212@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190904063240.GA24212@infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.2 cv=FNpr/6gs c=1 sm=1 tr=0 a=YO9NNpcXwc8z/SaoS+iAiA==:117 a=YO9NNpcXwc8z/SaoS+iAiA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=J70Eh1EUuV4A:10 a=7-415B0cAAAA:8 a=JjiOTFrwCe2sEW-orI4A:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Sep 03, 2019 at 11:32:40PM -0700, Christoph Hellwig wrote: > After going back to this from the next patch I think I spotted a > behavior difference: xlog_state_do_iclog_callbacks only returns true, > and xlog_state_do_callback only increments loopdidcallbacks if > ic_callbacks was non-emty. But we already dropped the block just > to check that it is empty, so I think we need to keep the old > behavior. IIUC, you are saying that loopdidcallbacks is not a variable that tracks whether callbacks were run, but whether the icloglock was released or not. Ok, I'll go fix that up, and name the variable appropriately. Cheers, Dave. -- Dave Chinner david@fromorbit.com