From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 5/7] xfs: factor iclog state processing out of xlog_state_do_callback()
Date: Thu, 5 Sep 2019 07:43:50 +1000 [thread overview]
Message-ID: <20190904214350.GH1119@dread.disaster.area> (raw)
In-Reply-To: <20190904064221.GA3960@infradead.org>
On Tue, Sep 03, 2019 at 11:42:21PM -0700, Christoph Hellwig wrote:
> On Wed, Sep 04, 2019 at 02:24:49PM +1000, Dave Chinner wrote:
> > + /* Skip all iclogs in the ACTIVE & DIRTY states */
> > + if (iclog->ic_state & (XLOG_STATE_ACTIVE|XLOG_STATE_DIRTY))
> > + return false;
>
> Please use spaces around the "|".
Fixed.
>
> > + if (iclog->ic_state & XLOG_STATE_IOERROR)
> > + ioerrors++;
>
> This now also counts the ierrror flag for dirty and active iclogs.
> Not sure it matters given our state machine, but it does change
> behavior.
True. There's an ioerror check in xlog_state_iodone_process_iclog()
so I can pass the ioerror parameter into it and retain the existing
logic.
> > + ret = xlog_state_iodone_process_iclog(log, iclog,
> > + ciclog);
> > + if (ret)
> > + break;
>
> No need for the ret variable.
Fixed.
> >
> > - } else
> > - ioerrors++;
> > + if (!(iclog->ic_state &
> > + (XLOG_STATE_CALLBACK | XLOG_STATE_IOERROR))) {
> > + iclog = iclog->ic_next;
> > + continue;
> > + }
>
> Btw, one cleanup I had pending is that all our loops ovr the iclog
> list can be cleaned up nicely so that continue does that right thing
> without all these manual "iclog = iclog->ic_next" next statements. Just
> turn the loop into:
>
> do {
> ..
> } while ((iclog = iclog->ic_next) != first_iclog);
>
> this might be applicable to a few of your patches.
Yup, as I mentioned earlier, that's in progress :P
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2019-09-04 21:43 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 4:24 [PATCH 0/7] xfs: log race fixes and cleanups Dave Chinner
2019-09-04 4:24 ` [PATCH 1/7] xfs: push the AIL in xlog_grant_head_wake Dave Chinner
2019-09-04 6:07 ` Christoph Hellwig
2019-09-04 21:46 ` Dave Chinner
2019-09-04 4:24 ` [PATCH 2/7] xfs: fix missed wakeup on l_flush_wait Dave Chinner
2019-09-04 6:07 ` Christoph Hellwig
2019-09-04 21:47 ` Dave Chinner
2019-09-04 4:24 ` [PATCH 3/7] xfs: factor debug code out of xlog_state_do_callback() Dave Chinner
2019-09-04 6:10 ` Christoph Hellwig
2019-09-04 21:14 ` Dave Chinner
2019-09-04 4:24 ` [PATCH 4/7] xfs: factor callbacks " Dave Chinner
2019-09-04 6:13 ` Christoph Hellwig
2019-09-04 6:32 ` Christoph Hellwig
2019-09-04 21:22 ` Dave Chinner
2019-09-04 4:24 ` [PATCH 5/7] xfs: factor iclog state processing " Dave Chinner
2019-09-04 6:42 ` Christoph Hellwig
2019-09-04 21:43 ` Dave Chinner [this message]
2019-09-04 4:24 ` [PATCH 6/7] xfs: push iclog state cleaning into xlog_state_clean_log Dave Chinner
2019-09-04 6:44 ` Christoph Hellwig
2019-09-04 4:24 ` [PATCH 7/7] xfs: push the grant head when the log head moves forward Dave Chinner
2019-09-04 6:45 ` Christoph Hellwig
2019-09-04 21:49 ` Dave Chinner
2019-09-04 19:34 ` Brian Foster
2019-09-04 22:50 ` Dave Chinner
2019-09-05 16:25 ` Brian Foster
2019-09-06 0:02 ` Dave Chinner
2019-09-06 13:10 ` Brian Foster
2019-09-07 15:10 ` Brian Foster
2019-09-08 23:26 ` Dave Chinner
2019-09-10 9:56 ` Brian Foster
2019-09-10 23:38 ` Dave Chinner
2019-09-12 13:46 ` Brian Foster
2019-09-17 4:31 ` Darrick J. Wong
2019-09-17 12:48 ` Brian Foster
2019-09-24 17:16 ` Darrick J. Wong
2019-09-26 13:19 ` Brian Foster
2019-09-04 5:26 ` [PATCH 0/7] xfs: log race fixes and cleanups Christoph Hellwig
2019-09-04 5:56 ` Christoph Hellwig
2019-09-04 22:57 ` Dave Chinner
[not found] ` <20190905065133.GA21840@infradead.org>
2019-09-05 7:10 ` Dave Chinner
2019-09-05 7:28 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904214350.GH1119@dread.disaster.area \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).