From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67054C3A59E for ; Wed, 4 Sep 2019 21:46:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 461EB21670 for ; Wed, 4 Sep 2019 21:46:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725965AbfIDVq0 (ORCPT ); Wed, 4 Sep 2019 17:46:26 -0400 Received: from mail105.syd.optusnet.com.au ([211.29.132.249]:50323 "EHLO mail105.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729626AbfIDVq0 (ORCPT ); Wed, 4 Sep 2019 17:46:26 -0400 Received: from dread.disaster.area (pa49-181-255-194.pa.nsw.optusnet.com.au [49.181.255.194]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id B7348362DE7; Thu, 5 Sep 2019 07:46:24 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92) (envelope-from ) id 1i5d6e-0007ib-8y; Thu, 05 Sep 2019 07:46:24 +1000 Date: Thu, 5 Sep 2019 07:46:24 +1000 From: Dave Chinner To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH 1/7] xfs: push the AIL in xlog_grant_head_wake Message-ID: <20190904214624.GI1119@dread.disaster.area> References: <20190904042451.9314-1-david@fromorbit.com> <20190904042451.9314-2-david@fromorbit.com> <20190904060707.GA12591@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190904060707.GA12591@infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.2 cv=P6RKvmIu c=1 sm=1 tr=0 a=YO9NNpcXwc8z/SaoS+iAiA==:117 a=YO9NNpcXwc8z/SaoS+iAiA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=J70Eh1EUuV4A:10 a=7-415B0cAAAA:8 a=fOb2UonkopxJ7jtyngoA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Sep 03, 2019 at 11:07:07PM -0700, Christoph Hellwig wrote: > > + if (*free_bytes < need_bytes) { > > + if (!woken_task) > > + xlog_grant_push_ail(log, need_bytes); > > return false; > > + } > > It would be nice to have a comment here with the condensed wisdom from > the commit log. Fixed. -- Dave Chinner david@fromorbit.com