From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 03/12] libfrog: move bitmap.h to libfrog/
Date: Thu, 5 Sep 2019 09:28:00 +1000 [thread overview]
Message-ID: <20190904232800.GR1119@dread.disaster.area> (raw)
In-Reply-To: <156757176284.1838135.8194717294650007232.stgit@magnolia>
On Tue, Sep 03, 2019 at 09:36:02PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Move this header to libfrog since the code is there already.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> include/bitmap.h | 24 ------------------------
> libfrog/Makefile | 1 +
> libfrog/bitmap.h | 24 ++++++++++++++++++++++++
> repair/rmap.c | 2 +-
> scrub/phase6.c | 2 +-
> 5 files changed, 27 insertions(+), 26 deletions(-)
> delete mode 100644 include/bitmap.h
> create mode 100644 libfrog/bitmap.h
looks good.
FWIW, given these are file moves, you could tell git to generate
move diffs rather than long form entire-file-changed diffs. The
shortform git diffs are a lot easier to review :P
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2019-09-04 23:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 4:35 [PATCH 00/12] libfrog: move header files Darrick J. Wong
2019-09-04 4:35 ` [PATCH 01/12] libxfs: move topology declarations into separate header Darrick J. Wong
2019-09-04 23:24 ` Dave Chinner
2019-09-04 4:35 ` [PATCH 02/12] libfrog: move avl64.h to libfrog/ Darrick J. Wong
2019-09-04 23:25 ` Dave Chinner
2019-09-04 4:36 ` [PATCH 03/12] libfrog: move bitmap.h " Darrick J. Wong
2019-09-04 23:28 ` Dave Chinner [this message]
2019-09-04 4:36 ` [PATCH 04/12] libfrog: move convert.h " Darrick J. Wong
2019-09-04 23:28 ` Dave Chinner
2019-09-04 4:36 ` [PATCH 05/12] libfrog: move fsgeom.h " Darrick J. Wong
2019-09-04 23:32 ` Dave Chinner
2019-09-04 4:36 ` [PATCH 06/12] libfrog: move ptvar.h " Darrick J. Wong
2019-09-04 23:32 ` Dave Chinner
2019-09-04 4:36 ` [PATCH 07/12] libfrog: move radix-tree.h " Darrick J. Wong
2019-09-04 23:33 ` Dave Chinner
2019-09-04 4:36 ` [PATCH 08/12] libfrog: move workqueue.h " Darrick J. Wong
2019-09-04 23:34 ` Dave Chinner
2019-09-04 4:36 ` [PATCH 09/12] libfrog: move crc32c.h " Darrick J. Wong
2019-09-04 23:37 ` Dave Chinner
2019-09-04 4:36 ` [PATCH 10/12] libfrog: move path.h " Darrick J. Wong
2019-09-04 23:39 ` Dave Chinner
2019-09-04 4:36 ` [PATCH 11/12] libfrog: move workqueue.h " Darrick J. Wong
2019-09-04 23:40 ` Dave Chinner
2019-09-04 4:36 ` [PATCH 12/12] libfrog: move libfrog.h to libfrog/util.h Darrick J. Wong
2019-09-04 23:43 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190904232800.GR1119@dread.disaster.area \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).