From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B430AC4740C for ; Mon, 9 Sep 2019 23:29:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 84FDE21A4A for ; Mon, 9 Sep 2019 23:29:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390047AbfIIX36 (ORCPT ); Mon, 9 Sep 2019 19:29:58 -0400 Received: from mail105.syd.optusnet.com.au ([211.29.132.249]:56146 "EHLO mail105.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730025AbfIIX36 (ORCPT ); Mon, 9 Sep 2019 19:29:58 -0400 Received: from dread.disaster.area (pa49-181-255-194.pa.nsw.optusnet.com.au [49.181.255.194]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id 8192E3619D4; Tue, 10 Sep 2019 09:29:55 +1000 (AEST) Received: from dave by dread.disaster.area with local (Exim 4.92.2) (envelope-from ) id 1i7T6Y-0006J6-8s; Tue, 10 Sep 2019 09:29:54 +1000 Date: Tue, 10 Sep 2019 09:29:54 +1000 From: Dave Chinner To: "Darrick J. Wong" Cc: sandeen@sandeen.net, linux-xfs@vger.kernel.org Subject: Re: [PATCH 1/5] xfs_scrub: remove unnecessary fd parameter from file scrubbers Message-ID: <20190909232954.GF16973@dread.disaster.area> References: <156774080205.2643094.9791648860536208060.stgit@magnolia> <156774080821.2643094.5031489896405041648.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <156774080821.2643094.5031489896405041648.stgit@magnolia> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.2 cv=D+Q3ErZj c=1 sm=1 tr=0 a=YO9NNpcXwc8z/SaoS+iAiA==:117 a=YO9NNpcXwc8z/SaoS+iAiA==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=J70Eh1EUuV4A:10 a=yPCof4ZbAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=JuDxSlhT3OO6blO4plAA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Thu, Sep 05, 2019 at 08:33:28PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong > > xfs_scrub's scrub ioctl wrapper functions always take a scrub_ctx and an > fd, but we always set the fd to ctx->mnt.fd. Remove the redundant > parameter. > > Signed-off-by: Darrick J. Wong > --- > scrub/phase3.c | 10 +++++----- > scrub/scrub.c | 34 ++++++++++++---------------------- > scrub/scrub.h | 16 ++++++++-------- > 3 files changed, 25 insertions(+), 35 deletions(-) Nice little cleanup. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com