From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: linux-xfs@vger.kernel.org, Dave Chinner <dchinner@redhat.com>
Subject: Re: [PATCH 04/10] man: document the new health reporting fields in various ioctls
Date: Mon, 16 Sep 2019 08:17:20 -0700 [thread overview]
Message-ID: <20190916151720.GT568270@magnolia> (raw)
In-Reply-To: <36de43a2-9adb-73db-81a1-eecb665113ea@sandeen.net>
On Mon, Sep 09, 2019 at 02:19:42PM -0500, Eric Sandeen wrote:
> On 9/3/19 11:37 PM, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > Update the manpages to conver the new health reporting fields in the
> > fs geometry, ag geometry, and bulkstat ioctls.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > Reviewed-by: Dave Chinner <dchinner@redhat.com>
> > ---
> > man/man2/ioctl_xfs_ag_geometry.2 | 48 +++++++++++++++++++++++++++++++
> > man/man2/ioctl_xfs_fsbulkstat.2 | 52 +++++++++++++++++++++++++++++++++
> > man/man2/ioctl_xfs_fsop_geometry.2 | 56 +++++++++++++++++++++++++++++++++++-
> > 3 files changed, 154 insertions(+), 2 deletions(-)
> >
> >
> ...
>
> > diff --git a/man/man2/ioctl_xfs_fsbulkstat.2 b/man/man2/ioctl_xfs_fsbulkstat.2
> > index a8b22dc4..3e13cfa8 100644
> > --- a/man/man2/ioctl_xfs_fsbulkstat.2
> > +++ b/man/man2/ioctl_xfs_fsbulkstat.2
> > @@ -94,7 +94,9 @@ struct xfs_bstat {
> > __u16 bs_projid_lo;
> > __u16 bs_forkoff;
> > __u16 bs_projid_hi;
> > - unsigned char bs_pad[6];
> > + uint16_t bs_sick;
> > + uint16_t bs_checked;
> > + unsigned char bs_pad[2];
> > __u32 bs_cowextsize;
> > __u32 bs_dmevmask;
> > __u16 bs_dmstate;
> > @@ -184,6 +186,54 @@ is unused on Linux.
> > .I bs_aextents
> > is the number of storage mappings associated with this file's extended
> > attributes.
> > +.PP
> > +The fields
> > +.IR bs_sick " and " bs_checked
> > +indicate the relative health of various allocation group metadata:
>
>
> This should probably say "inode metadata?"
Yes it should have, thanks for fixing that.
--D
> I can fix that on the way in, the rest looks ok
>
> Reviewed-by: Eric Sandeen <sandeen@redhat.com>
>
next prev parent reply other threads:[~2019-09-16 15:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 4:37 [PATCH v2 00/10] xfsprogs-5.3: various fixes Darrick J. Wong
2019-09-04 4:37 ` [PATCH 01/10] man: document the new v5 fs geometry ioctl structures Darrick J. Wong
2019-09-09 18:24 ` Eric Sandeen
2019-09-04 4:37 ` [PATCH 02/10] man: document new fs summary counter scrub command Darrick J. Wong
2019-09-09 18:25 ` Eric Sandeen
2019-09-04 4:37 ` [PATCH 03/10] man: document the new allocation group geometry ioctl Darrick J. Wong
2019-09-09 18:51 ` Eric Sandeen
2019-09-04 4:37 ` [PATCH 04/10] man: document the new health reporting fields in various ioctls Darrick J. Wong
2019-09-09 19:19 ` Eric Sandeen
2019-09-16 15:17 ` Darrick J. Wong [this message]
2019-09-04 4:37 ` [PATCH 05/10] xfs_db: remove db/convert.h Darrick J. Wong
2019-09-09 19:24 ` Eric Sandeen
2019-09-04 4:37 ` [PATCH 06/10] xfs_db: add a function to compute btree geometry Darrick J. Wong
2019-09-04 4:37 ` [PATCH 07/10] xfs_db: use precomputed inode geometry values Darrick J. Wong
2019-09-04 4:37 ` [PATCH 08/10] xfs_repair: " Darrick J. Wong
2019-09-04 4:38 ` [PATCH 09/10] xfs_repair: reduce the amount of "clearing reflink flag" messages Darrick J. Wong
2019-09-04 4:38 ` [PATCH 10/10] xfs_repair: add AG btree rmaps into the filesystem after syncing sb Darrick J. Wong
2019-09-09 19:28 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190916151720.GT568270@magnolia \
--to=darrick.wong@oracle.com \
--cc=dchinner@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).