From: Christoph Hellwig <hch@infradead.org>
To: Brian Foster <bfoster@redhat.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH v2 2/3] xfs: remove broken error handling on failed attr sf to leaf change
Date: Tue, 8 Oct 2019 00:00:05 -0700 [thread overview]
Message-ID: <20191008070005.GB21805@infradead.org> (raw)
In-Reply-To: <20191007131938.23839-3-bfoster@redhat.com>
On Mon, Oct 07, 2019 at 09:19:37AM -0400, Brian Foster wrote:
> xfs_attr_shortform_to_leaf() attempts to put the shortform fork back
> together after a failed attempt to convert from shortform to leaf
> format. While this code reallocates and copies back the shortform
> attr fork data, it never resets the inode format field back to local
> format. Further, now that the inode is properly logged after the
> initial switch from local format, any error that triggers the
> recovery code will eventually abort the transaction and shutdown the
> fs. Therefore, remove the broken and unnecessary error handling
> code.
>
> Signed-off-by: Brian Foster <bfoster@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2019-10-08 7:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 13:19 [PATCH v2 0/3] xfs: fix sf to block inode fork logging Brian Foster
2019-10-07 13:19 ` [PATCH v2 1/3] xfs: log the inode on directory sf to block format change Brian Foster
2019-10-08 6:59 ` Christoph Hellwig
2019-10-08 16:11 ` Darrick J. Wong
2019-10-07 13:19 ` [PATCH v2 2/3] xfs: remove broken error handling on failed attr sf to leaf change Brian Foster
2019-10-08 7:00 ` Christoph Hellwig [this message]
2019-10-08 16:11 ` Darrick J. Wong
2019-10-07 13:19 ` [PATCH v2 3/3] xfs: move local to extent inode logging into bmap helper Brian Foster
2019-10-08 7:00 ` Christoph Hellwig
2019-10-08 16:11 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008070005.GB21805@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).