From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Ian Kent <raven@themaw.net>,
linux-xfs <linux-xfs@vger.kernel.org>,
Brian Foster <bfoster@redhat.com>,
Eric Sandeen <sandeen@sandeen.net>,
David Howells <dhowells@redhat.com>,
Dave Chinner <dchinner@redhat.com>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v5 08/17] xfs: mount-api - move xfs_parseargs() validation to a helper
Date: Wed, 9 Oct 2019 23:38:24 -0700 [thread overview]
Message-ID: <20191010063824.GA15004@infradead.org> (raw)
In-Reply-To: <20191009194747.GH13108@magnolia>
On Wed, Oct 09, 2019 at 12:47:47PM -0700, Darrick J. Wong wrote:
> On Wed, Oct 09, 2019 at 08:02:06AM -0700, Christoph Hellwig wrote:
> > On Wed, Oct 09, 2019 at 07:30:52PM +0800, Ian Kent wrote:
> > > +#ifndef CONFIG_XFS_QUOTA
> > > + if (XFS_IS_QUOTA_RUNNING(mp)) {
> > > + xfs_warn(mp, "quota support not available in this kernel.");
> > > + return -EINVAL;
> > > + }
> > > +#endif
> >
> > this can use IS_ENABLED.
>
> I didn't think that macro needed a CONFIG_XFS_QUOTA check...?
Even better if we don't need anything at al..
next prev parent reply other threads:[~2019-10-10 6:38 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 11:30 [PATCH v5 00/17] xfs: mount API patch series Ian Kent
2019-10-09 11:30 ` [PATCH v5 01/17] vfs: Create fs_context-aware mount_bdev() replacement Ian Kent
2019-10-09 11:30 ` [PATCH v5 02/17] vfs: add missing blkdev_put() in get_tree_bdev() Ian Kent
2019-10-09 11:30 ` [PATCH v5 03/17] xfs: remove very old mount option Ian Kent
2019-10-09 11:30 ` [PATCH v5 04/17] xfs: mount-api - add fs parameter description Ian Kent
2019-10-09 14:48 ` Christoph Hellwig
2019-10-10 0:56 ` Ian Kent
2019-10-10 6:39 ` Christoph Hellwig
2019-10-10 8:31 ` Ian Kent
2019-10-09 14:53 ` Christoph Hellwig
2019-10-09 11:30 ` [PATCH v5 05/17] xfs: mount-api - refactor suffix_kstrtoint() Ian Kent
2019-10-09 14:48 ` Christoph Hellwig
2019-10-09 15:21 ` Al Viro
2019-10-09 15:29 ` Christoph Hellwig
2019-10-09 16:03 ` Al Viro
2019-10-09 18:01 ` Christoph Hellwig
2019-10-09 18:22 ` Al Viro
2019-12-06 8:27 ` Christoph Hellwig
2019-10-10 0:59 ` Ian Kent
2019-10-09 11:30 ` [PATCH v5 06/17] xfs: mount-api - refactor xfs_parseags() Ian Kent
2019-10-09 14:56 ` Christoph Hellwig
2019-10-10 1:08 ` Ian Kent
2019-10-09 11:30 ` [PATCH v5 07/17] xfs: mount-api - make xfs_parse_param() take context .parse_param() args Ian Kent
2019-10-09 11:30 ` [PATCH v5 08/17] xfs: mount-api - move xfs_parseargs() validation to a helper Ian Kent
2019-10-09 15:02 ` Christoph Hellwig
2019-10-09 19:47 ` Darrick J. Wong
2019-10-10 6:38 ` Christoph Hellwig [this message]
2019-10-10 7:57 ` Christoph Hellwig
2019-10-09 11:30 ` [PATCH v5 09/17] xfs: mount-api - refactor xfs_fs_fill_super() Ian Kent
2019-10-09 15:03 ` Christoph Hellwig
2019-10-10 1:10 ` Ian Kent
2019-10-09 11:31 ` [PATCH v5 10/17] xfs: mount-api - add xfs_get_tree() Ian Kent
2019-10-09 15:04 ` Christoph Hellwig
2019-10-10 1:11 ` Ian Kent
2019-10-09 11:31 ` [PATCH v5 11/17] xfs: mount-api - add xfs_remount_rw() helper Ian Kent
2019-10-09 11:31 ` [PATCH v5 12/17] xfs: mount-api - add xfs_remount_ro() helper Ian Kent
2019-10-09 11:31 ` [PATCH v5 13/17] xfs: mount api - add xfs_reconfigure() Ian Kent
2019-10-09 12:51 ` Brian Foster
2019-10-09 15:05 ` Christoph Hellwig
2019-10-10 1:12 ` Ian Kent
2019-10-09 11:31 ` [PATCH v5 14/17] xfs: mount-api - add xfs_fc_free() Ian Kent
2019-10-09 12:51 ` Brian Foster
2019-10-09 11:31 ` [PATCH v5 15/17] xfs: mount-api - dont set sb in xfs_mount_alloc() Ian Kent
2019-10-09 11:31 ` [PATCH v5 16/17] xfs: mount-api - switch to new mount-api Ian Kent
2019-10-09 15:10 ` Christoph Hellwig
2019-10-10 1:15 ` Ian Kent
2019-10-09 11:31 ` [PATCH v5 17/17] xfs: mount-api - remove remaining legacy mount code Ian Kent
2019-10-09 15:10 ` Christoph Hellwig
2019-10-10 1:17 ` Ian Kent
2019-10-09 14:52 ` [PATCH v5 00/17] xfs: mount API patch series Christoph Hellwig
2019-10-14 1:28 ` Ian Kent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010063824.GA15004@infradead.org \
--to=hch@infradead.org \
--cc=bfoster@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=dchinner@redhat.com \
--cc=dhowells@redhat.com \
--cc=linux-xfs@vger.kernel.org \
--cc=raven@themaw.net \
--cc=sandeen@sandeen.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).