From: Christoph Hellwig <hch@lst.de>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] xfs: disable xfs_ioc_space for always COW inodes
Date: Mon, 14 Oct 2019 09:18:27 +0200 [thread overview]
Message-ID: <20191014071827.GD10081@lst.de> (raw)
In-Reply-To: <20191012002954.GM13108@magnolia>
On Fri, Oct 11, 2019 at 05:29:54PM -0700, Darrick J. Wong wrote:
> On Fri, Oct 11, 2019 at 03:03:15PM +0200, Christoph Hellwig wrote:
> > If we always have to write out of place preallocating blocks is
> > pointless. We already check for this in the normal falloc path, but
> > the check was missig in the legacy ALLOCSP path.
>
> This function handles other things than preallocation, such as
> XFS_IOC_ZERO_RANGE and XFS_IOC_UNRESVSP, which call xfs_zero_file_space
> and xfs_free_file_space, respectively. We don't prohibit fallocate
> from calling those two functions on an always_cow inode, so why do that
> here?
True. I actually have a patch in my tree that switches those to
be handled in the core so that they enter XFS through ->fallocate.
It didn't make any sense to send this patch before that other change,
sorry.
next prev parent reply other threads:[~2019-10-14 7:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 13:03 small fixes for the always_cow mode Christoph Hellwig
2019-10-11 13:03 ` [PATCH 1/2] xfs: disable xfs_ioc_space for always COW inodes Christoph Hellwig
2019-10-12 0:29 ` Darrick J. Wong
2019-10-14 7:18 ` Christoph Hellwig [this message]
2019-10-11 13:03 ` [PATCH 2/2] xfs: ignore extent size hints " Christoph Hellwig
2019-10-12 0:32 ` Darrick J. Wong
2019-10-14 7:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191014071827.GD10081@lst.de \
--to=hch@lst.de \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).