From: Christoph Hellwig <hch@infradead.org>
To: Shaokun Zhang <zhangshaokun@hisilicon.com>
Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
Yang Guo <guoyang2@huawei.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>
Subject: Re: [PATCH] xfs: optimise xfs_mod_icount/ifree when delta < 0
Date: Mon, 4 Nov 2019 07:25:17 -0800 [thread overview]
Message-ID: <20191104152517.GD10485@infradead.org> (raw)
In-Reply-To: <1572866980-13001-1-git-send-email-zhangshaokun@hisilicon.com>
On Mon, Nov 04, 2019 at 07:29:40PM +0800, Shaokun Zhang wrote:
> From: Yang Guo <guoyang2@huawei.com>
>
> percpu_counter_compare will be called by xfs_mod_icount/ifree to check
> whether the counter less than 0 and it is a expensive function.
> let's check it only when delta < 0, it will be good for xfs's performance.
How much overhead do you see? In the end the compare is just a debug
check, so if it actually shows up we should remove it entirely.
next prev parent reply other threads:[~2019-11-04 15:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 11:29 [PATCH] xfs: optimise xfs_mod_icount/ifree when delta < 0 Shaokun Zhang
2019-11-04 15:25 ` Christoph Hellwig [this message]
2019-11-05 3:08 ` Shaokun Zhang
2019-11-04 20:49 ` Dave Chinner
2019-11-05 3:26 ` Shaokun Zhang
2019-11-05 4:03 ` Dave Chinner
2019-11-06 6:00 ` Shaokun Zhang
2019-11-06 21:20 ` Dave Chinner
2019-11-08 5:58 ` Shaokun Zhang
2019-11-15 9:16 ` Shaokun Zhang
2019-11-18 8:12 ` Dave Chinner
2019-11-20 21:08 ` Dave Chinner
2019-11-21 6:56 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104152517.GD10485@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=guoyang2@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=zhangshaokun@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).