From: Allison Collins <allison.henderson@oracle.com>
To: linux-xfs@vger.kernel.org
Subject: [PATCH v4 02/17] xfsprogs: Replace attribute parameters with struct xfs_name
Date: Wed, 6 Nov 2019 18:29:30 -0700 [thread overview]
Message-ID: <20191107012945.22941-3-allison.henderson@oracle.com> (raw)
In-Reply-To: <20191107012945.22941-1-allison.henderson@oracle.com>
This patch replaces the attribute name and length parameters with a
single struct xfs_name parameter. This helps to clean up the numbers of
parameters being passed around and pre-simplifies the code some.
Signed-off-by: Allison Collins <allison.henderson@oracle.com>
---
db/attrset.c | 12 +++++++++---
libxfs/libxfs_priv.h | 12 +++++-------
libxfs/xfs_attr.c | 22 +++++++++-------------
libxfs/xfs_attr.h | 12 +++++-------
4 files changed, 28 insertions(+), 30 deletions(-)
diff --git a/db/attrset.c b/db/attrset.c
index 5c0ec6e9..f606d0a 100644
--- a/db/attrset.c
+++ b/db/attrset.c
@@ -68,6 +68,7 @@ attr_set_f(
{
xfs_inode_t *ip = NULL;
char *name, *value, *sp;
+ struct xfs_name xname;
int c, valuelen = 0, flags = 0;
if (cur_typ == NULL) {
@@ -146,8 +147,10 @@ attr_set_f(
goto out;
}
- if (libxfs_attr_set(ip, (unsigned char *)name, strlen(name),
- (unsigned char *)value, valuelen, flags)) {
+ xname.name = name;
+ xname.len = strlen(name);
+ if (libxfs_attr_set(ip, &xname, (unsigned char *)value, valuelen,
+ flags)) {
dbprintf(_("failed to set attr %s on inode %llu\n"),
name, (unsigned long long)iocur_top->ino);
goto out;
@@ -172,6 +175,7 @@ attr_remove_f(
{
xfs_inode_t *ip = NULL;
char *name;
+ struct xfs_name xname;
int c, flags = 0;
if (cur_typ == NULL) {
@@ -222,7 +226,9 @@ attr_remove_f(
goto out;
}
- if (libxfs_attr_remove(ip, (unsigned char *)name, strlen(name), flags)) {
+ xname.name = name;
+ xname.len = strlen(name);
+ if (libxfs_attr_remove(ip, &xname, flags)) {
dbprintf(_("failed to remove attr %s from inode %llu\n"),
name, (unsigned long long)iocur_top->ino);
goto out;
diff --git a/libxfs/libxfs_priv.h b/libxfs/libxfs_priv.h
index c06984b..e1a3c11 100644
--- a/libxfs/libxfs_priv.h
+++ b/libxfs/libxfs_priv.h
@@ -609,13 +609,11 @@ static inline int test_and_set_bit(int nr, volatile unsigned long *addr)
/* Keep static checkers quiet about nonstatic functions by exporting */
int xfs_inode_hasattr(struct xfs_inode *ip);
int xfs_attr_get_ilocked(struct xfs_inode *ip, struct xfs_da_args *args);
-int xfs_attr_get(struct xfs_inode *ip, const unsigned char *name,
- size_t namelen, unsigned char *value, int *valuelenp,
- int flags);
-int xfs_attr_set(struct xfs_inode *dp, const unsigned char *name,
- size_t namelen, unsigned char *value, int valuelen, int flags);
-int xfs_attr_remove(struct xfs_inode *dp, const unsigned char *name,
- size_t namelen, int flags);
+int xfs_attr_get(struct xfs_inode *ip, struct xfs_name *name,
+ unsigned char *value, int *valuelenp, int flags);
+int xfs_attr_set(struct xfs_inode *dp, struct xfs_name *name,
+ unsigned char *value, int valuelen, int flags);
+int xfs_attr_remove(struct xfs_inode *dp, struct xfs_name *name, int flags);
int xfs_rtbuf_get(struct xfs_mount *mp, struct xfs_trans *tp,
xfs_rtblock_t block, int issum, struct xfs_buf **bpp);
int xfs_rtcheck_range(struct xfs_mount *mp, struct xfs_trans *tp,
diff --git a/libxfs/xfs_attr.c b/libxfs/xfs_attr.c
index 158afe3..742575c 100644
--- a/libxfs/xfs_attr.c
+++ b/libxfs/xfs_attr.c
@@ -60,8 +60,7 @@ STATIC int
xfs_attr_args_init(
struct xfs_da_args *args,
struct xfs_inode *dp,
- const unsigned char *name,
- size_t namelen,
+ struct xfs_name *name,
int flags)
{
@@ -73,8 +72,8 @@ xfs_attr_args_init(
args->whichfork = XFS_ATTR_FORK;
args->dp = dp;
args->flags = flags;
- args->name = name;
- args->namelen = namelen;
+ args->name = name->name;
+ args->namelen = name->len;
if (args->namelen >= MAXNAMELEN)
return -EFAULT; /* match IRIX behaviour */
@@ -119,8 +118,7 @@ xfs_attr_get_ilocked(
int
xfs_attr_get(
struct xfs_inode *ip,
- const unsigned char *name,
- size_t namelen,
+ struct xfs_name *name,
unsigned char *value,
int *valuelenp,
int flags)
@@ -134,7 +132,7 @@ xfs_attr_get(
if (XFS_FORCED_SHUTDOWN(ip->i_mount))
return -EIO;
- error = xfs_attr_args_init(&args, ip, name, namelen, flags);
+ error = xfs_attr_args_init(&args, ip, name, flags);
if (error)
return error;
@@ -305,8 +303,7 @@ xfs_attr_remove_args(
int
xfs_attr_set(
struct xfs_inode *dp,
- const unsigned char *name,
- size_t namelen,
+ struct xfs_name *name,
unsigned char *value,
int valuelen,
int flags)
@@ -322,7 +319,7 @@ xfs_attr_set(
if (XFS_FORCED_SHUTDOWN(dp->i_mount))
return -EIO;
- error = xfs_attr_args_init(&args, dp, name, namelen, flags);
+ error = xfs_attr_args_init(&args, dp, name, flags);
if (error)
return error;
@@ -410,8 +407,7 @@ out_trans_cancel:
int
xfs_attr_remove(
struct xfs_inode *dp,
- const unsigned char *name,
- size_t namelen,
+ struct xfs_name *name,
int flags)
{
struct xfs_mount *mp = dp->i_mount;
@@ -423,7 +419,7 @@ xfs_attr_remove(
if (XFS_FORCED_SHUTDOWN(dp->i_mount))
return -EIO;
- error = xfs_attr_args_init(&args, dp, name, namelen, flags);
+ error = xfs_attr_args_init(&args, dp, name, flags);
if (error)
return error;
diff --git a/libxfs/xfs_attr.h b/libxfs/xfs_attr.h
index 69493b5..ad62d3f 100644
--- a/libxfs/xfs_attr.h
+++ b/libxfs/xfs_attr.h
@@ -142,14 +142,12 @@ int xfs_attr_list_int_ilocked(struct xfs_attr_list_context *);
int xfs_attr_list_int(struct xfs_attr_list_context *);
int xfs_inode_hasattr(struct xfs_inode *ip);
int xfs_attr_get_ilocked(struct xfs_inode *ip, struct xfs_da_args *args);
-int xfs_attr_get(struct xfs_inode *ip, const unsigned char *name,
- size_t namelen, unsigned char *value, int *valuelenp,
- int flags);
-int xfs_attr_set(struct xfs_inode *dp, const unsigned char *name,
- size_t namelen, unsigned char *value, int valuelen, int flags);
+int xfs_attr_get(struct xfs_inode *ip, struct xfs_name *name,
+ unsigned char *value, int *valuelenp, int flags);
+int xfs_attr_set(struct xfs_inode *dp, struct xfs_name *name,
+ unsigned char *value, int valuelen, int flags);
int xfs_attr_set_args(struct xfs_da_args *args);
-int xfs_attr_remove(struct xfs_inode *dp, const unsigned char *name,
- size_t namelen, int flags);
+int xfs_attr_remove(struct xfs_inode *dp, struct xfs_name *name, int flags);
int xfs_attr_remove_args(struct xfs_da_args *args);
int xfs_attr_list(struct xfs_inode *dp, char *buffer, int bufsize,
int flags, struct attrlist_cursor_kern *cursor);
--
2.7.4
next prev parent reply other threads:[~2019-11-07 1:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-07 1:29 [PATCH v4 00/17] xfsprogs: Delayed Ready Attributes Allison Collins
2019-11-07 1:29 ` [PATCH v4 01/17] xfsprogs: Remove all strlen in all xfs_attr_* functions for attr names Allison Collins
2019-11-07 1:29 ` Allison Collins [this message]
2019-11-07 1:29 ` [PATCH v4 03/17] xfsprogs: Embed struct xfs_name in xfs_da_args Allison Collins
2019-11-07 1:29 ` [PATCH v4 04/17] xfsprogs: Add xfs_dabuf defines Allison Collins
2019-11-07 1:29 ` [PATCH v4 05/17] xfsprogs: Add xfs_has_attr and subroutines Allison Collins
2019-11-07 1:29 ` [PATCH v4 06/17] xfsprogs: Factor out new helper functions xfs_attr_rmtval_set Allison Collins
2019-11-07 1:29 ` [PATCH v4 07/17] xfsprogs: Factor up trans handling in xfs_attr3_leaf_flipflags Allison Collins
2019-11-07 1:29 ` [PATCH v4 08/17] xfsprogs: Factor out xfs_attr_leaf_addname helper Allison Collins
2019-11-07 1:29 ` [PATCH v4 09/17] xfsprogs: Factor up commit from xfs_attr_try_sf_addname Allison Collins
2019-11-07 1:29 ` [PATCH v4 10/17] xfsprogs: Factor up trans roll from xfs_attr3_leaf_setflag Allison Collins
2019-11-07 1:29 ` [PATCH v4 11/17] xfsprogs: Add xfs_attr3_leaf helper functions Allison Collins
2019-11-07 1:29 ` [PATCH v4 12/17] xfsprogs: Factor out xfs_attr_rmtval_invalidate Allison Collins
2019-11-07 1:29 ` [PATCH v4 13/17] xfsprogs: Factor up trans roll in xfs_attr3_leaf_clearflag Allison Collins
2019-11-07 1:29 ` [PATCH v4 14/17] xfsprogs: Add delay context to xfs_da_args Allison Collins
2019-11-07 1:29 ` [PATCH v4 15/17] xfsprogs: Check for -ENOATTR or -EEXIST Allison Collins
2019-11-07 1:29 ` [PATCH v4 16/17] xfsprogs: Add delay ready attr remove routines Allison Collins
2019-11-07 1:29 ` [PATCH v4 17/17] xfsprogs: Add delay ready attr set routines Allison Collins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191107012945.22941-3-allison.henderson@oracle.com \
--to=allison.henderson@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).