From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8832C5DF61 for ; Thu, 7 Nov 2019 08:30:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AC3832187F for ; Thu, 7 Nov 2019 08:30:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733196AbfKGIaw (ORCPT ); Thu, 7 Nov 2019 03:30:52 -0500 Received: from verein.lst.de ([213.95.11.211]:55725 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726734AbfKGIaw (ORCPT ); Thu, 7 Nov 2019 03:30:52 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id F1A0168C7B; Thu, 7 Nov 2019 09:30:50 +0100 (CET) Date: Thu, 7 Nov 2019 09:30:50 +0100 From: Christoph Hellwig To: "Darrick J. Wong" Cc: Christoph Hellwig , linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH] iomap: iomap_bmap should check iomap_apply return value Message-ID: <20191107083050.GB9802@lst.de> References: <20191107025927.GA6219@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191107025927.GA6219@magnolia> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, Nov 06, 2019 at 06:59:27PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong > > Check the return value of iomap_apply and return 0 (i.e. error) if it > didn't succeed. And how could we set the bno value if we didn't succeed?