From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>, linux-xfs@vger.kernel.org
Subject: Re: [PATCH 2/3] xfs: clean up weird while loop in xfs_alloc_ag_vextent_near
Date: Thu, 7 Nov 2019 23:22:52 -0800 [thread overview]
Message-ID: <20191108072252.GB14546@infradead.org> (raw)
In-Reply-To: <20191108072002.GO6219@magnolia>
On Thu, Nov 07, 2019 at 11:20:02PM -0800, Darrick J. Wong wrote:
> On Thu, Nov 07, 2019 at 11:11:51PM -0800, Christoph Hellwig wrote:
> > What tree is this supposed to apply to? It fails against
>
> Sorry, I've been reworking these patches against a branch that I hadn't
> yet pushed to xfs-linux.git (and won't until I can take one more look
> tomorrow with a fresh brain).
>
> In the meantime, you can see my development branch on my personal git
> repo:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git/log/?h=xfs-5.5-dev
>
> > xfs/for-next here. Otherwise this looks fine to me.
>
> Fine enough for an RVB provided the above? :D
Sure, it _looks_ good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
Although I'd love to be able to at least do a quick xfstests run on
it..
next prev parent reply other threads:[~2019-11-08 7:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 7:04 [PATCH v2 0/3] xfs: various coverity fixes Darrick J. Wong
2019-11-08 7:04 ` [PATCH 1/3] xfs: annotate functions that trip static checker locking checks Darrick J. Wong
2019-11-08 7:05 ` Christoph Hellwig
2019-11-08 7:04 ` [PATCH 2/3] xfs: clean up weird while loop in xfs_alloc_ag_vextent_near Darrick J. Wong
2019-11-08 7:11 ` Christoph Hellwig
2019-11-08 7:20 ` Darrick J. Wong
2019-11-08 7:22 ` Christoph Hellwig [this message]
2019-11-08 7:05 ` [PATCH 3/3] xfs: actually check xfs_btree_check_block return in xfs_btree_islastblock Darrick J. Wong
2019-11-08 7:14 ` Christoph Hellwig
2019-11-08 7:29 ` Darrick J. Wong
2019-11-08 7:33 ` Christoph Hellwig
2019-11-08 7:46 ` Darrick J. Wong
2019-11-08 7:47 ` Darrick J. Wong
2019-11-18 10:59 ` Carlos Maiolino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108072252.GB14546@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).