From: Christoph Hellwig <firstname.lastname@example.org> To: "Darrick J. Wong" <email@example.com> Cc: firstname.lastname@example.org, email@example.com Subject: Re: [PATCH 3/3] xfs: attach dquots before performing xfs_swap_extents Date: Mon, 11 Nov 2019 00:05:03 -0800 Message-ID: <20191111080503.GC4548@infradead.org> (raw) In-Reply-To: <157343511427.1948946.2692071497822316839.stgit@magnolia> On Sun, Nov 10, 2019 at 05:18:34PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <firstname.lastname@example.org> > > Make sure we attach dquots to both inodes before swapping their extents. > This was found via manual code inspection by looking for places where we > could call xfs_trans_mod_dquot without dquots attached to inodes, and > confirmed by instrumenting the kernel and running xfs/328. Looks good: Reviewed-by: Christoph Hellwig <email@example.com> Btw, for while I've been wondering if we could just get rid of the concepts of attached dquots. With the radix-tree/xarray looks up are be fairly cheap, and could be done lockless using RCU. So we could try to just kill the concept of attaching the dquot to the inode and just look it up once per operation, where operation preferally is something high-level like the actual file/inode operation and not a low-level thing inside xfs.
next prev parent reply index Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-11-11 1:18 [PATCH 0/3] xfs: various fixes Darrick J. Wong 2019-11-11 1:18 ` [PATCH 1/3] xfs: actually check xfs_btree_check_block return in xfs_btree_islastblock Darrick J. Wong 2019-11-11 7:57 ` Christoph Hellwig 2019-11-11 1:18 ` [PATCH 2/3] xfs: attach dquots and reserve quota blocks during unwritten conversion Darrick J. Wong 2019-11-11 7:59 ` Christoph Hellwig 2019-11-11 1:18 ` [PATCH 3/3] xfs: attach dquots before performing xfs_swap_extents Darrick J. Wong 2019-11-11 8:05 ` Christoph Hellwig [this message] 2019-11-12 22:14 ` Dave Chinner 2019-11-14 14:53 ` Christoph Hellwig
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191111080503.GC4548@infradead.org \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-XFS Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-xfs/0 linux-xfs/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-xfs linux-xfs/ https://lore.kernel.org/linux-xfs \ email@example.com public-inbox-index linux-xfs Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-xfs AGPL code for this site: git clone https://public-inbox.org/public-inbox.git