From: Christoph Hellwig <hch@infradead.org>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, hch@infradead.org, david@fromorbit.org
Subject: Re: [PATCH 2/3] xfs: kill the XFS_WANT_CORRUPT_* macros
Date: Mon, 11 Nov 2019 00:51:17 -0800 [thread overview]
Message-ID: <20191111085117.GA5729@infradead.org> (raw)
In-Reply-To: <157343508488.1945685.9867882880040545380.stgit@magnolia>
I have to say I really hate the macro that includes the actual
if statement.
On Sun, Nov 10, 2019 at 05:18:05PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> The XFS_WANT_CORRUPT_* macros conceal subtle side effects such as the
> creation of local variables and redirections of the code flow. This is
> pretty ugly, so replace them with explicit if_xfs_meta_bad() tests that
> remove both of those ugly points. First we use Cocinelle to expand the
> macros into an if test and braces with the following coccinelle script:
Also all this seems to be out of date.
next prev parent reply other threads:[~2019-11-11 8:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 1:17 [PATCH v4 0/3] xfs: refactor corruption returns Darrick J. Wong
2019-11-11 1:17 ` [PATCH 1/3] xfs: add a if_xfs_meta_bad macro for testing and logging bad metadata Darrick J. Wong
2019-11-11 13:51 ` Brian Foster
2019-11-13 0:01 ` Darrick J. Wong
2019-11-11 1:18 ` [PATCH 2/3] xfs: kill the XFS_WANT_CORRUPT_* macros Darrick J. Wong
2019-11-11 8:51 ` Christoph Hellwig [this message]
2019-11-12 23:08 ` Darrick J. Wong
2019-11-11 1:18 ` [PATCH 3/3] xfs: convert open coded corruption check to use XFS_IS_CORRUPT Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111085117.GA5729@infradead.org \
--to=hch@infradead.org \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).