From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39917C43603 for ; Wed, 4 Dec 2019 20:58:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0EB9320656 for ; Wed, 4 Dec 2019 20:58:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727961AbfLDU6X (ORCPT ); Wed, 4 Dec 2019 15:58:23 -0500 Received: from mail104.syd.optusnet.com.au ([211.29.132.246]:40972 "EHLO mail104.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727889AbfLDU6X (ORCPT ); Wed, 4 Dec 2019 15:58:23 -0500 Received: from dread.disaster.area (pa49-179-150-192.pa.nsw.optusnet.com.au [49.179.150.192]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 01E4A7E9D8D; Thu, 5 Dec 2019 07:58:20 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1icbj2-0005xm-1b; Thu, 05 Dec 2019 07:58:20 +1100 Date: Thu, 5 Dec 2019 07:58:20 +1100 From: Dave Chinner To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org, jstancek@redhat.com Subject: Re: [PATCH] xfs: fix sub-page uptodate handling Message-ID: <20191204205820.GN2695@dread.disaster.area> References: <20191204172804.6589-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191204172804.6589-1-hch@lst.de> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=X6os11be c=1 sm=1 tr=0 a=ZXpxJgW8/q3NVgupyyvOCQ==:117 a=ZXpxJgW8/q3NVgupyyvOCQ==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=pxVhFHJ0LMsA:10 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=-8oLzmg_bMdD26dgm7MA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Wed, Dec 04, 2019 at 06:28:04PM +0100, Christoph Hellwig wrote: > bio complentions can race when a page spans more than one file system > block. Add a spinlock to synchronize marking the page uptodate. > > Fixes: 9dc55f1389f9 ("iomap: add support for sub-pagesize buffered I/O without buffer heads") > Reported-by: Jan Stancek > Signed-off-by: Christoph Hellwig Looks sane, similar fix to previous completion issues like this. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com