From: "Darrick J. Wong" <darrick.wong@oracle.com> To: Ira Weiny <ira.weiny@intel.com> Cc: linux-kernel@vger.kernel.org, Alexander Viro <viro@zeniv.linux.org.uk>, Dan Williams <dan.j.williams@intel.com>, Dave Chinner <david@fromorbit.com>, Christoph Hellwig <hch@lst.de>, "Theodore Y. Ts'o" <tytso@mit.edu>, Jan Kara <jack@suse.cz>, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: Re: [RFC PATCH V2 10/12] fs/xfs: Fix truncate up Date: Mon, 13 Jan 2020 17:14:07 -0800 Message-ID: <20200114011407.GT8247@magnolia> (raw) In-Reply-To: <20200114004047.GC29860@iweiny-DESK2.sc.intel.com> On Mon, Jan 13, 2020 at 04:40:47PM -0800, Ira Weiny wrote: > On Mon, Jan 13, 2020 at 02:27:55PM -0800, Darrick J. Wong wrote: > > On Fri, Jan 10, 2020 at 11:29:40AM -0800, ira.weiny@intel.com wrote: > > > From: Ira Weiny <ira.weiny@intel.com> > > > > > > When zeroing the end of a file we must account for bytes contained in > > > the final page which are past EOF. > > > > > > Extend the range passed to iomap_zero_range() to reach LLONG_MAX which > > > will include all bytes of the final page. > > > > > > Signed-off-by: Ira Weiny <ira.weiny@intel.com> > > > --- > > > fs/xfs/xfs_iops.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/fs/xfs/xfs_iops.c b/fs/xfs/xfs_iops.c > > > index a2f2604c3187..a34b04e8ac9c 100644 > > > --- a/fs/xfs/xfs_iops.c > > > +++ b/fs/xfs/xfs_iops.c > > > @@ -910,7 +910,7 @@ xfs_setattr_size( > > > */ > > > if (newsize > oldsize) { > > > trace_xfs_zero_eof(ip, oldsize, newsize - oldsize); > > > - error = iomap_zero_range(inode, oldsize, newsize - oldsize, > > > + error = iomap_zero_range(inode, oldsize, LLONG_MAX - oldsize, > > > > Huh? Won't this cause the file size to be set to LLONG_MAX? > > Not as I understand the code. iomap_zero_range uses the standard iomap_write_{begin,end} functions, which means that if you pass it an (offset, length) that extend beyond EOF it will change isize to offset+length. > But as I said in the cover I am not 100% sure of > this fix. > From what I can tell xfs_ioctl_setattr_dax_invalidate() should invalidate the > mappings and the page cache and the traces I have indicate that the DAX mode > is not changing or was properly held off. Hmm, that implies the invalidation didn't work. Can you find a way to report the contents of the page cache after the dax mode change invalidation fails? I wonder if this is something dorky like rounding down such that the EOF page doesn't actually get invalidated? Hmm, no, xfs_ioctl_setattr_dax_invalidate should be nuking all the pages... do you have a quick reproducer? --D > Any other suggestions as to the problem are welcome. > > Ira > > > > > > --D > > > > > &did_zeroing, &xfs_buffered_write_iomap_ops); > > > } else { > > > error = iomap_truncate_page(inode, newsize, &did_zeroing, > > > -- > > > 2.21.0 > > >
next prev parent reply index Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-10 19:29 [RFC PATCH V2 00/12] Enable per-file/directory DAX operations V2 ira.weiny 2020-01-10 19:29 ` [RFC PATCH V2 01/12] fs/stat: Define DAX statx attribute ira.weiny 2020-01-15 11:37 ` Jan Kara 2020-01-15 17:38 ` Darrick J. Wong 2020-01-15 19:45 ` Ira Weiny 2020-01-15 20:10 ` Dan Williams 2020-01-15 22:38 ` Ira Weiny 2020-01-16 5:39 ` Darrick J. Wong 2020-01-16 6:05 ` Dan Williams 2020-01-16 6:18 ` Darrick J. Wong 2020-01-16 6:25 ` Dan Williams 2020-01-18 9:11 ` Dave Chinner 2020-01-16 17:55 ` Ira Weiny 2020-01-16 18:04 ` Darrick J. Wong 2020-01-16 18:52 ` Ira Weiny 2020-01-16 22:19 ` Darrick J. Wong 2020-01-17 11:58 ` Jan Kara 2020-01-10 19:29 ` [RFC PATCH V2 02/12] fs/xfs: Isolate the physical DAX flag from effective ira.weiny 2020-01-10 19:29 ` [RFC PATCH V2 03/12] fs/xfs: Separate functionality of xfs_inode_supports_dax() ira.weiny 2020-01-10 19:29 ` [RFC PATCH V2 04/12] fs/xfs: Clean up DAX support check ira.weiny 2020-01-10 19:29 ` [RFC PATCH V2 05/12] fs: remove unneeded IS_DAX() check ira.weiny 2020-01-16 9:38 ` Jan Kara 2020-01-16 18:47 ` Ira Weiny 2020-01-10 19:29 ` [RFC PATCH V2 06/12] fs/xfs: Check if the inode supports DAX under lock ira.weiny 2020-01-10 19:29 ` [RFC PATCH V2 07/12] fs: Add locking for a dynamic inode 'mode' ira.weiny 2020-01-13 22:12 ` Darrick J. Wong 2020-01-14 0:20 ` Ira Weiny 2020-01-14 1:03 ` Darrick J. Wong 2020-01-15 19:08 ` Ira Weiny 2020-01-16 5:40 ` Darrick J. Wong 2020-01-16 18:54 ` Ira Weiny 2020-01-10 19:29 ` [RFC PATCH V2 08/12] fs/xfs: Add lock/unlock mode to xfs ira.weiny 2020-01-13 22:19 ` Darrick J. Wong 2020-01-14 0:35 ` Ira Weiny 2020-01-15 0:57 ` Ira Weiny 2020-01-15 23:52 ` Ira Weiny 2020-01-16 9:24 ` Jan Kara 2020-01-16 19:12 ` Ira Weiny 2020-01-10 19:29 ` [RFC PATCH V2 09/12] fs: Prevent mode change if file is mmap'ed ira.weiny 2020-01-13 22:22 ` Darrick J. Wong 2020-01-14 0:46 ` Ira Weiny 2020-01-14 1:30 ` Darrick J. Wong 2020-01-14 17:53 ` Ira Weiny 2020-01-15 11:34 ` Jan Kara 2020-01-15 18:24 ` Ira Weiny 2020-01-15 10:21 ` David Laight 2020-01-15 17:53 ` Ira Weiny 2020-01-10 19:29 ` [RFC PATCH V2 10/12] fs/xfs: Fix truncate up ira.weiny 2020-01-13 22:27 ` Darrick J. Wong 2020-01-14 0:40 ` Ira Weiny 2020-01-14 1:14 ` Darrick J. Wong [this message] 2020-01-14 19:00 ` Ira Weiny 2020-01-14 19:39 ` Ira Weiny 2020-01-10 19:29 ` [RFC PATCH V2 11/12] fs/xfs: Clean up locking in dax invalidate ira.weiny 2020-01-10 19:29 ` [RFC PATCH V2 12/12] fs/xfs: Allow toggle of effective DAX flag ira.weiny
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200114011407.GT8247@magnolia \ --to=darrick.wong@oracle.com \ --cc=dan.j.williams@intel.com \ --cc=david@fromorbit.com \ --cc=hch@lst.de \ --cc=ira.weiny@intel.com \ --cc=jack@suse.cz \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-xfs@vger.kernel.org \ --cc=tytso@mit.edu \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Linux-XFS Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/linux-xfs/0 linux-xfs/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 linux-xfs linux-xfs/ https://lore.kernel.org/linux-xfs \ linux-xfs@vger.kernel.org public-inbox-index linux-xfs Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-xfs AGPL code for this site: git clone https://public-inbox.org/public-inbox.git