From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF1A1C33CB1 for ; Tue, 14 Jan 2020 08:15:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8B5182053B for ; Tue, 14 Jan 2020 08:15:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="F/8M/FBs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726121AbgANIPh (ORCPT ); Tue, 14 Jan 2020 03:15:37 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:42176 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726053AbgANIPg (ORCPT ); Tue, 14 Jan 2020 03:15:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From:Sender :Reply-To:Content-Type:Content-ID:Content-Description:Resent-Date:Resent-From :Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=xrcZeYWeZHVf9mnPuNHC0d+RPbHN+uxecCL63JD0jrY=; b=F/8M/FBso/n6Ny6b2FMDUfyiM3 GTUDVqbsXAQy0HZBijJF6zL2v7FQ/iPfGw7lYdESoPRNYPd3k2Lc5VJ0m0p9qWs39PRcyScamgGUz htzAyiALwdwZ7DnFEk6JH2MgdDRDs28TtXWdZdJl59nX2yezIOaSiT8ItxyxpSjpQ3hC/X0U2O9hQ 0ZKDYkgwF/3SnN/Zyvyar9QUGNLdSW0eAFvR4H1NCa3vTVU8ZUCE2P0CrkdVp9Ypb+U7LuO1dvpvG fb3dWQGbwodx3Sqq1/IOvmI5yhovNgdb2eL5nbisBqTwwYlt7FzZ67uRTsyn6QCsBUUZG6r+mxv/q OVvm6U4g==; Received: from [2001:4bb8:18c:4f54:fcbb:a92b:61e1:719] (helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1irHMO-0006yb-84; Tue, 14 Jan 2020 08:15:36 +0000 From: Christoph Hellwig To: linux-xfs@vger.kernel.org Cc: Allison Collins Subject: [PATCH 07/29] xfs: remove the MAXNAMELEN check from xfs_attr_args_init Date: Tue, 14 Jan 2020 09:10:29 +0100 Message-Id: <20200114081051.297488-8-hch@lst.de> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200114081051.297488-1-hch@lst.de> References: <20200114081051.297488-1-hch@lst.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org All the callers already check the length when allocating the in-kernel xattrs buffers. Signed-off-by: Christoph Hellwig --- fs/xfs/libxfs/xfs_attr.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/xfs/libxfs/xfs_attr.c b/fs/xfs/libxfs/xfs_attr.c index d5064213577c..ef3c851cd278 100644 --- a/fs/xfs/libxfs/xfs_attr.c +++ b/fs/xfs/libxfs/xfs_attr.c @@ -72,9 +72,6 @@ xfs_attr_args_init( args->flags = flags; args->name = name; args->namelen = namelen; - if (args->namelen >= MAXNAMELEN) - return -EFAULT; /* match IRIX behaviour */ - args->hashval = xfs_da_hashname(args->name, args->namelen); return 0; } -- 2.24.1