From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Vincenzo Frascino <vincenzo.frascino@arm.com>
Cc: hch@lst.de, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xfs: Add __packed to xfs_dir2_sf_entry_t definition
Date: Tue, 14 Jan 2020 16:43:53 -0800 [thread overview]
Message-ID: <20200115004353.GX8247@magnolia> (raw)
In-Reply-To: <20200114120352.53111-1-vincenzo.frascino@arm.com>
On Tue, Jan 14, 2020 at 12:03:52PM +0000, Vincenzo Frascino wrote:
> xfs_check_ondisk_structs() verifies that the sizes of the data types
> used by xfs are correct via the XFS_CHECK_STRUCT_SIZE() macro.
>
> Since the structures padding can vary depending on the ABI (e.g. on
> ARM OABI structures are padded to multiple of 32 bits), it may happen
> that xfs_dir2_sf_entry_t size check breaks the compilation with the
> assertion below:
>
> In file included from linux/include/linux/string.h:6,
> from linux/include/linux/uuid.h:12,
> from linux/fs/xfs/xfs_linux.h:10,
> from linux/fs/xfs/xfs.h:22,
> from linux/fs/xfs/xfs_super.c:7:
> In function ‘xfs_check_ondisk_structs’,
> inlined from ‘init_xfs_fs’ at linux/fs/xfs/xfs_super.c:2025:2:
> linux/include/linux/compiler.h:350:38:
> error: call to ‘__compiletime_assert_107’ declared with attribute
> error: XFS: sizeof(xfs_dir2_sf_entry_t) is wrong, expected 3
> _compiletime_assert(condition, msg, __compiletime_assert_, __LINE__)
>
> Restore the correct behavior adding __packed to the structure definition.
>
> Cc: Darrick J. Wong <darrick.wong@oracle.com>
> Suggested-by: Christoph Hellwig <hch@lst.de>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
Will give this a spin,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> fs/xfs/libxfs/xfs_da_format.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/xfs/libxfs/xfs_da_format.h b/fs/xfs/libxfs/xfs_da_format.h
> index 3dee33043e09..60db25f30430 100644
> --- a/fs/xfs/libxfs/xfs_da_format.h
> +++ b/fs/xfs/libxfs/xfs_da_format.h
> @@ -217,7 +217,7 @@ typedef struct xfs_dir2_sf_entry {
> * A 64-bit or 32-bit inode number follows here, at a variable offset
> * after the name.
> */
> -} xfs_dir2_sf_entry_t;
> +} __packed xfs_dir2_sf_entry_t;
>
> static inline int xfs_dir2_sf_hdr_size(int i8count)
> {
> --
> 2.24.1
>
prev parent reply other threads:[~2020-01-15 0:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 12:03 [PATCH] xfs: Add __packed to xfs_dir2_sf_entry_t definition Vincenzo Frascino
2020-01-14 15:45 ` Christoph Hellwig
2020-01-15 0:43 ` Darrick J. Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200115004353.GX8247@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=vincenzo.frascino@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).