archive mirror
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <>
To: "yukuai (C)" <>
Subject: Re: [PATCH] xfs/126: fix that corrupt xattr might fail with a small probability
Date: Thu, 16 Jan 2020 08:03:23 -0800	[thread overview]
Message-ID: <20200116160323.GC2149943@magnolia> (raw)
In-Reply-To: <>

On Thu, Jan 16, 2020 at 08:22:00PM +0800, yukuai (C) wrote:
> ON 2020/1/10 0:46, Darrick J. Wong wrote:
> > It sounds like a reasonable idea, though I was suggesting doing the
> > snapshot-and-check in the xfs_db source, not fstests.
> The problem is that blocktrash do changed some bits of the attr block,
> however, corrupt will still fail if the change is only inside the 'zero'
> range.
> So, I think it's hard to fix the problem by doing the snapshot-and-check
> in the xfs_db source.


I'm a little concerned about having a static seed though, since the
xfs_db rng isn't great.

Does adding "-o 4" to the blocktrash command make it work reliably?
That should be close enough to the start of the attrleaf block that
we'll reliably corrupt *some* amount of stuff in the header.


> Thanks!
> Yu Kuai

  reply	other threads:[~2020-01-16 16:04 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-08  9:27 yu kuai
2020-01-08 16:22 ` Darrick J. Wong
2020-01-09  3:56   ` yukuai (C)
2020-01-09  4:00   ` yukuai (C)
2020-01-09 16:46     ` Darrick J. Wong
2020-01-16 12:22       ` yukuai (C)
2020-01-16 16:03         ` Darrick J. Wong [this message]
2020-01-17  2:20           ` yukuai (C)
2020-01-17  3:10             ` yukuai (C)
2020-01-17  6:15               ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200116160323.GC2149943@magnolia \ \ \ \ \ \ \ \ \
    --subject='Re: [PATCH] xfs/126: fix that corrupt xattr might fail with a small probability' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).