From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 6/9] xfs: make xfs_buf_get_map return an error code
Date: Thu, 16 Jan 2020 14:33:56 -0800 [thread overview]
Message-ID: <20200116223356.GI8247@magnolia> (raw)
In-Reply-To: <20200116162856.GF3802@infradead.org>
On Thu, Jan 16, 2020 at 08:28:56AM -0800, Christoph Hellwig wrote:
> > error = xfs_buf_find(target, map, nmaps, flags, NULL, &bp);
> > -
> > switch (error) {
> > case 0:
> > /* cache hit */
> > goto found;
> > - case -EAGAIN:
> > - /* cache hit, trylock failure, caller handles failure */
> > - ASSERT(flags & XBF_TRYLOCK);
> > - return NULL;
> > case -ENOENT:
> > /* cache miss, go for insert */
> > break;
> > + case -EAGAIN:
> > + /* cache hit, trylock failure, caller handles failure */
> > + ASSERT(flags & XBF_TRYLOCK);
> > + /* fall through */
> > case -EFSCORRUPTED:
> > default:
> > - /*
> > - * None of the higher layers understand failure types
> > - * yet, so return NULL to signal a fatal lookup error.
> > - */
> > - return NULL;
> > + return error;
>
> I think two little if statements would be cleaner with two ifs instead
> of the switch statement:
>
> if (!error)
> goto found;
> if (error != -ENOENT)
> return error;
>
> Otherwise looks good:
Will fix.
--D
> Reviewed-by: Christoph Hellwig <hch@lst.de>
next prev parent reply other threads:[~2020-01-16 22:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-15 17:03 [PATCH 0/9] xfs: make buffer functions return error codes Darrick J. Wong
2020-01-15 17:03 ` [PATCH 1/9] xfs: make xfs_buf_alloc return an error code Darrick J. Wong
2020-01-16 16:13 ` Christoph Hellwig
2020-01-15 17:03 ` [PATCH 2/9] xfs: make xfs_buf_read " Darrick J. Wong
2020-01-16 16:15 ` Christoph Hellwig
2020-01-16 22:30 ` Darrick J. Wong
2020-01-15 17:03 ` [PATCH 3/9] xfs: make xfs_buf_get " Darrick J. Wong
2020-01-16 16:16 ` Christoph Hellwig
2020-01-16 22:30 ` Darrick J. Wong
2020-01-15 17:04 ` [PATCH 4/9] xfs: make xfs_buf_get_uncached " Darrick J. Wong
2020-01-16 16:17 ` Christoph Hellwig
2020-01-15 17:04 ` [PATCH 5/9] xfs: make xfs_buf_read_map " Darrick J. Wong
2020-01-16 16:21 ` Christoph Hellwig
2020-01-16 23:26 ` Darrick J. Wong
2020-01-15 17:04 ` [PATCH 6/9] xfs: make xfs_buf_get_map " Darrick J. Wong
2020-01-16 16:28 ` Christoph Hellwig
2020-01-16 22:33 ` Darrick J. Wong [this message]
2020-01-15 17:04 ` [PATCH 7/9] xfs: make xfs_trans_get_buf_map " Darrick J. Wong
2020-01-16 16:29 ` Christoph Hellwig
2020-01-15 17:04 ` [PATCH 8/9] xfs: make xfs_trans_get_buf " Darrick J. Wong
2020-01-16 16:31 ` Christoph Hellwig
2020-01-15 17:04 ` [PATCH 9/9] xfs: make xfs_btree_get_buf functions " Darrick J. Wong
2020-01-16 16:33 ` Christoph Hellwig
2020-01-16 16:43 ` Christoph Hellwig
2020-01-16 22:40 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200116223356.GI8247@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).