From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4820FC33CAA for ; Tue, 21 Jan 2020 18:03:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0E37324125 for ; Tue, 21 Jan 2020 18:03:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="o08jzGYR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729121AbgAUSDZ (ORCPT ); Tue, 21 Jan 2020 13:03:25 -0500 Received: from aserp2120.oracle.com ([141.146.126.78]:37172 "EHLO aserp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728901AbgAUSDZ (ORCPT ); Tue, 21 Jan 2020 13:03:25 -0500 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00LHmSBk136335; Tue, 21 Jan 2020 18:03:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2019-08-05; bh=J+lGEsi1NUnfqzxEiBSd3i7oPBFU1MFFPfHMNq6EB6k=; b=o08jzGYRihMCG+z3wNAIXi2dcXBFeWz2LCQSvv15EUFDJHPKmzqJ82Bno5BKreZiJNph jIrP4SceWHkaJLYsRK4GAwI3FC59+bTKn9TdoHeKeduMW0nTNoiSmQg0C1s+K9jghg7j btgP3EVYYaT1D0ZnHWJvrDSRgVmASPmppjHGZFJjfUqDbJZ2yImWGsgARqFHFf0HI1+O Kx1lqPb+sbJLKSjozRxkM959d3ZIE40Xn6HWZBK5wsOP07OMIjQfooTnDW48T59i0ZTk zUvCaMwD8SYMdI7bH73SbePB2f5ZS3pYBo55zloLEUMO40ljoIz0EWC0yF+/IbYX37wp UQ== Received: from aserp3020.oracle.com (aserp3020.oracle.com [141.146.126.70]) by aserp2120.oracle.com with ESMTP id 2xksyq6rwr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Jan 2020 18:03:22 +0000 Received: from pps.filterd (aserp3020.oracle.com [127.0.0.1]) by aserp3020.oracle.com (8.16.0.27/8.16.0.27) with SMTP id 00LHnirh173336; Tue, 21 Jan 2020 18:03:22 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3020.oracle.com with ESMTP id 2xnpef6w77-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Jan 2020 18:03:21 +0000 Received: from abhmp0010.oracle.com (abhmp0010.oracle.com [141.146.116.16]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 00LI3Ken020588; Tue, 21 Jan 2020 18:03:20 GMT Received: from localhost (/67.169.218.210) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 21 Jan 2020 10:03:20 -0800 Date: Tue, 21 Jan 2020 10:03:18 -0800 From: "Darrick J. Wong" To: Christoph Hellwig Cc: linux-xfs@vger.kernel.org, Allison Collins Subject: Re: [PATCH 07/29] xfs: remove the MAXNAMELEN check from xfs_attr_args_init Message-ID: <20200121180318.GH8247@magnolia> References: <20200114081051.297488-1-hch@lst.de> <20200114081051.297488-8-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200114081051.297488-8-hch@lst.de> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9507 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001210137 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9507 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1911140001 definitions=main-2001210137 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Jan 14, 2020 at 09:10:29AM +0100, Christoph Hellwig wrote: > All the callers already check the length when allocating the > in-kernel xattrs buffers. > > Signed-off-by: Christoph Hellwig Looks ok, Reviewed-by: Darrick J. Wong --D > --- > fs/xfs/libxfs/xfs_attr.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/fs/xfs/libxfs/xfs_attr.c b/fs/xfs/libxfs/xfs_attr.c > index d5064213577c..ef3c851cd278 100644 > --- a/fs/xfs/libxfs/xfs_attr.c > +++ b/fs/xfs/libxfs/xfs_attr.c > @@ -72,9 +72,6 @@ xfs_attr_args_init( > args->flags = flags; > args->name = name; > args->namelen = namelen; > - if (args->namelen >= MAXNAMELEN) > - return -EFAULT; /* match IRIX behaviour */ > - > args->hashval = xfs_da_hashname(args->name, args->namelen); > return 0; > } > -- > 2.24.1 >