From: Dave Chinner <david@fromorbit.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: linux-xfs@vger.kernel.org, hch@infradead.org
Subject: Re: [PATCH 03/12] xfs: make xfs_buf_read_map return an error code
Date: Sat, 25 Jan 2020 09:05:04 +1100 [thread overview]
Message-ID: <20200124220504.GO7090@dread.disaster.area> (raw)
In-Reply-To: <157984315522.3139258.1946613629222213561.stgit@magnolia>
On Thu, Jan 23, 2020 at 09:19:15PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> Convert xfs_buf_read_map() to return numeric error codes like most
> everywhere else in xfs. This involves moving the open-coded logic that
> reports metadata IO read / corruption errors and stales the buffer into
> xfs_buf_read_map so that the logic is all in one place.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
> fs/xfs/libxfs/xfs_alloc.c | 11 ++++---
> fs/xfs/libxfs/xfs_attr_remote.c | 10 ------
> fs/xfs/xfs_buf.c | 63 +++++++++++++++++++++++++++++----------
> fs/xfs/xfs_buf.h | 15 ++++++---
> fs/xfs/xfs_log_recover.c | 10 ------
> fs/xfs/xfs_symlink.c | 10 ------
> fs/xfs/xfs_trans_buf.c | 36 +++++-----------------
> 7 files changed, 72 insertions(+), 83 deletions(-)
Error handling in xfs_trans_read_buf_map() looks ok now.
Reviewed-by: Dave Chinner <dchinner@redhat.com>
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2020-01-24 22:05 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 5:18 [PATCH v5 00/12] xfs: make buffer functions return error codes Darrick J. Wong
2020-01-24 5:19 ` [PATCH 01/12] xfs: make xfs_buf_alloc return an error code Darrick J. Wong
2020-01-24 5:19 ` [PATCH 02/12] xfs: make xfs_buf_get_map " Darrick J. Wong
2020-01-24 22:02 ` Dave Chinner
2020-01-24 22:59 ` Christoph Hellwig
2020-01-24 5:19 ` [PATCH 03/12] xfs: make xfs_buf_read_map " Darrick J. Wong
2020-01-24 22:05 ` Dave Chinner [this message]
2020-01-24 23:07 ` Christoph Hellwig
2020-01-24 5:19 ` [PATCH 04/12] xfs: make xfs_buf_get " Darrick J. Wong
2020-01-24 5:19 ` [PATCH 05/12] xfs: make xfs_buf_get_uncached " Darrick J. Wong
2020-01-24 5:19 ` [PATCH 06/12] xfs: make xfs_buf_read " Darrick J. Wong
2020-01-24 22:05 ` Dave Chinner
2020-01-24 23:08 ` Christoph Hellwig
2020-01-24 5:19 ` [PATCH 07/12] xfs: make xfs_trans_get_buf_map " Darrick J. Wong
2020-01-24 5:19 ` [PATCH 08/12] xfs: make xfs_trans_get_buf " Darrick J. Wong
2020-01-24 5:19 ` [PATCH 09/12] xfs: remove the xfs_btree_get_buf[ls] functions Darrick J. Wong
2020-01-24 5:20 ` [PATCH 10/12] xfs: make xfs_*read_agf return EAGAIN to ALLOC_FLAG_TRYLOCK callers Darrick J. Wong
2020-01-24 22:07 ` Dave Chinner
2020-01-24 23:12 ` Christoph Hellwig
2020-01-26 2:43 ` Christoph Hellwig
2020-01-24 5:20 ` [PATCH 11/12] xfs: remove unnecessary null pointer checks from _read_agf callers Darrick J. Wong
2020-01-24 5:20 ` [PATCH 12/12] xfs: fix xfs_buf_ioerror_alert location reporting Darrick J. Wong
2020-01-24 23:12 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200124220504.GO7090@dread.disaster.area \
--to=david@fromorbit.com \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).