From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09AE4C2D0CE for ; Fri, 24 Jan 2020 22:07:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE8FA2071A for ; Fri, 24 Jan 2020 22:07:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726885AbgAXWH1 (ORCPT ); Fri, 24 Jan 2020 17:07:27 -0500 Received: from mail104.syd.optusnet.com.au ([211.29.132.246]:44373 "EHLO mail104.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725821AbgAXWH1 (ORCPT ); Fri, 24 Jan 2020 17:07:27 -0500 Received: from dread.disaster.area (pa49-195-162-125.pa.nsw.optusnet.com.au [49.195.162.125]) by mail104.syd.optusnet.com.au (Postfix) with ESMTPS id 7C4FA5EA7B7; Sat, 25 Jan 2020 09:07:25 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1iv76r-0007VG-0Z; Sat, 25 Jan 2020 09:07:25 +1100 Date: Sat, 25 Jan 2020 09:07:24 +1100 From: Dave Chinner To: "Darrick J. Wong" Cc: linux-xfs@vger.kernel.org, hch@infradead.org Subject: Re: [PATCH 10/12] xfs: make xfs_*read_agf return EAGAIN to ALLOC_FLAG_TRYLOCK callers Message-ID: <20200124220724.GQ7090@dread.disaster.area> References: <157984313582.3139258.1136501362141645797.stgit@magnolia> <157984320125.3139258.966527323692871610.stgit@magnolia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <157984320125.3139258.966527323692871610.stgit@magnolia> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=X6os11be c=1 sm=1 tr=0 a=eqEhQ2W7mF93FbYHClaXRw==:117 a=eqEhQ2W7mF93FbYHClaXRw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=Jdjhy38mL1oA:10 a=yPCof4ZbAAAA:8 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=LRuxdFmCzyi2J10UJcwA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Thu, Jan 23, 2020 at 09:20:01PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong > > Refactor xfs_read_agf and xfs_alloc_read_agf to return EAGAIN if the > caller passed TRYLOCK and we weren't able to get the lock; and change > the callers to recognize this. > > Signed-off-by: Darrick J. Wong > --- > fs/xfs/libxfs/xfs_alloc.c | 36 ++++++++++++++---------------------- > fs/xfs/libxfs/xfs_bmap.c | 11 ++++++----- > fs/xfs/xfs_filestream.c | 11 +++++------ > 3 files changed, 25 insertions(+), 33 deletions(-) The alloc flag assert changes make the error handling much simpler :) Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com