From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/5] xfsprogs: remove the ENABLE_GETTEXT substitution in platform_defs.h.in
Date: Sun, 26 Jan 2020 14:12:48 -0800 [thread overview]
Message-ID: <20200126221248.GD3447196@magnolia> (raw)
In-Reply-To: <20200126113541.787884-2-hch@lst.de>
On Sun, Jan 26, 2020 at 12:35:37PM +0100, Christoph Hellwig wrote:
> ENABLE_GETTEXT is already defined on the command line if enabled, no
> need to duplicate it in platform_defs.h.in.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Seems reasonable, though I wonder
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
> include/platform_defs.h.in | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/platform_defs.h.in b/include/platform_defs.h.in
> index 1f7ceafb..6cc56e31 100644
> --- a/include/platform_defs.h.in
> +++ b/include/platform_defs.h.in
> @@ -36,8 +36,6 @@ typedef struct filldir filldir_t;
> typedef unsigned short umode_t;
> #endif
>
> -/* Define if you want gettext (I18N) support */
> -#undef ENABLE_GETTEXT
> #ifdef ENABLE_GETTEXT
> # include <libintl.h>
> # define _(x) gettext(x)
> --
> 2.24.1
>
next prev parent reply other threads:[~2020-01-26 22:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-26 11:35 stop generating platform_defs.h Christoph Hellwig
2020-01-26 11:35 ` [PATCH 1/5] xfsprogs: remove the ENABLE_GETTEXT substitution in platform_defs.h.in Christoph Hellwig
2020-01-26 22:12 ` Darrick J. Wong [this message]
2020-01-26 11:35 ` [PATCH 2/5] xfsprogs: remove the SIZEOF_CHAR_P " Christoph Hellwig
2020-01-26 22:13 ` Darrick J. Wong
2020-01-26 11:35 ` [PATCH 3/5] repair: remove BITS_PER_LONG cpp checks in bmap.[ch] Christoph Hellwig
2020-01-26 22:20 ` Darrick J. Wong
2020-01-26 11:35 ` [PATCH 4/5] xfsprogs: remove the SIZEOF_LONG substitution in platform_defs.h.in Christoph Hellwig
2020-01-26 22:20 ` Darrick J. Wong
2020-01-26 11:35 ` [PATCH 5/5] xfsprogs: stop generating platform_defs.h Christoph Hellwig
2020-01-26 22:21 ` Darrick J. Wong
2020-01-29 6:49 stop generating platform_defs.h V2 Christoph Hellwig
2020-01-29 6:49 ` [PATCH 1/5] xfsprogs: remove the ENABLE_GETTEXT substitution in platform_defs.h.in Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200126221248.GD3447196@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).