From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2484C35242 for ; Wed, 12 Feb 2020 00:38:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A5D9920848 for ; Wed, 12 Feb 2020 00:38:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728060AbgBLAiZ (ORCPT ); Tue, 11 Feb 2020 19:38:25 -0500 Received: from mail105.syd.optusnet.com.au ([211.29.132.249]:47562 "EHLO mail105.syd.optusnet.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728057AbgBLAiZ (ORCPT ); Tue, 11 Feb 2020 19:38:25 -0500 Received: from dread.disaster.area (pa49-179-138-28.pa.nsw.optusnet.com.au [49.179.138.28]) by mail105.syd.optusnet.com.au (Postfix) with ESMTPS id ADC963A396D; Wed, 12 Feb 2020 11:38:21 +1100 (AEDT) Received: from dave by dread.disaster.area with local (Exim 4.92.3) (envelope-from ) id 1j1g2n-0004LM-4L; Wed, 12 Feb 2020 11:38:21 +1100 Date: Wed, 12 Feb 2020 11:38:21 +1100 From: Dave Chinner To: Pavel Reichl Cc: linux-xfs@vger.kernel.org Subject: Re: [PATCH v4 3/4] xfs: Fix bug when checking diff. locks Message-ID: <20200212003821.GQ10776@dread.disaster.area> References: <20200211221018.709125-1-preichl@redhat.com> <20200211221018.709125-3-preichl@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200211221018.709125-3-preichl@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Optus-CM-Score: 0 X-Optus-CM-Analysis: v=2.3 cv=LYdCFQXi c=1 sm=1 tr=0 a=zAxSp4fFY/GQY8/esVNjqw==:117 a=zAxSp4fFY/GQY8/esVNjqw==:17 a=jpOVt7BSZ2e4Z31A5e1TngXxSK0=:19 a=kj9zAlcOel0A:10 a=l697ptgUJYAA:10 a=20KFwNOVAAAA:8 a=7-415B0cAAAA:8 a=UD9wB-r_hoJu2ZtOc3wA:9 a=CjuIK1q_8ugA:10 a=biEYGPWJfzWAr4FL6Ov7:22 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Tue, Feb 11, 2020 at 11:10:17PM +0100, Pavel Reichl wrote: > In its current form, xfs_isilocked() is only able to test one lock type at a > time - ilock, iolock, or mmap lock, but combinations are not properly handled. > The intent here is to check that both XFS_IOLOCK_EXCL and XFS_ILOCK_EXCL are > held, so test them each separately. > > The commit ecfea3f0c8c6 ("xfs: split xfs_bmap_shift_extents") ORed the flags > together which was an error, so this patch reverts that part of the change and > check the locks independently. Commit message should wrap at 68-72 columns. > Fixes: ecfea3f0c8c6 ("xfs: split xfs_bmap_shift_extents") > > Reviewed-by: Eric Sandeen > Suggested-by: Dave Chinner > Signed-off-by: Pavel Reichl > --- > Changelog from V3: > Commit message extened. Same comment as the previous patch about the subject - "fix" and abbreviations. xfs: xfs_isilocked() can only check a single lock type Cheers, Dave. -- Dave Chinner david@fromorbit.com