From: "Darrick J. Wong" <darrick.wong@oracle.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Pavel Reichl <preichl@redhat.com>,
Eric Sandeen <sandeen@sandeen.net>,
linux-xfs@vger.kernel.org
Subject: Re: [PATCH v5 1/4] xfs: Refactor xfs_isilocked()
Date: Thu, 20 Feb 2020 09:27:08 -0800 [thread overview]
Message-ID: <20200220172708.GH9504@magnolia> (raw)
In-Reply-To: <20200220163232.GA1651@infradead.org>
On Thu, Feb 20, 2020 at 08:32:32AM -0800, Christoph Hellwig wrote:
> On Thu, Feb 20, 2020 at 05:30:35PM +0100, Pavel Reichl wrote:
> > OK, thanks for the comments.
> >
> > Eric in the following code is WARN_ONCE() used as you suggested or did
> > you have something else in mind?
> >
> > static inline bool
> > __xfs_rwsem_islocked(
> > struct rw_semaphore *rwsem,
> > bool excl)
> > {
> > if (!rwsem_is_locked(rwsem)) {
> > return false;
> > }
> >
> > if (excl) {
> > if (debug_locks) {
> > return lockdep_is_held_type(rwsem, 1);
> > }
> > WARN_ONCE(1,
> > "xfs rwsem lock testing coverage has been reduced\n");
> > }
>
> Yikes, hell no. This means every debug xfs build without lockdep
> will be full of warnings all the time.
Well... once per module load, but if you /were/ going to go down this
route I'd at least gate the warning on IS_ENABLED(CONFIG_LOCKDEP) so
that we only get this one-time warning when lockdep is enabled but dies
anyway, so that we'll know that we're running with half a brain.
--D
next prev parent reply other threads:[~2020-02-20 17:27 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-14 18:59 [PATCH v5 1/4] xfs: Refactor xfs_isilocked() Pavel Reichl
2020-02-14 18:59 ` [PATCH v5 2/4] xfs: clean up whitespace in xfs_isilocked() calls Pavel Reichl
2020-02-16 22:36 ` Dave Chinner
2020-02-17 13:33 ` Christoph Hellwig
2020-02-14 18:59 ` [PATCH v5 3/4] xfs: xfs_isilocked() can only check a single lock type Pavel Reichl
2020-02-16 22:37 ` Dave Chinner
2020-02-17 13:34 ` Christoph Hellwig
2020-02-14 18:59 ` [PATCH v5 4/4] xfs: replace mrlock_t with rw_semaphores Pavel Reichl
2020-02-16 22:39 ` Dave Chinner
2020-02-17 13:35 ` Christoph Hellwig
2020-02-15 1:38 ` [PATCH v5 1/4] xfs: Refactor xfs_isilocked() Chaitanya Kulkarni
2020-02-17 10:55 ` Pavel Reichl
2020-02-20 16:25 ` Chaitanya Kulkarni
2020-02-16 22:36 ` Dave Chinner
2020-02-17 13:35 ` Christoph Hellwig
2020-02-19 4:48 ` Darrick J. Wong
2020-02-19 17:31 ` Pavel Reichl
2020-02-19 18:40 ` Christoph Hellwig
2020-02-19 20:16 ` Eric Sandeen
2020-02-20 16:30 ` Pavel Reichl
2020-02-20 16:32 ` Christoph Hellwig
2020-02-20 17:26 ` Eric Sandeen
2020-02-20 17:27 ` Darrick J. Wong [this message]
2020-02-21 17:49 ` Pavel Reichl
2020-02-21 20:28 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220172708.GH9504@magnolia \
--to=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=preichl@redhat.com \
--cc=sandeen@sandeen.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).