From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CE79C38BFA for ; Mon, 24 Feb 2020 22:30:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 08E1A21927 for ; Mon, 24 Feb 2020 22:30:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="DOTQdzCP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727219AbgBXWaf (ORCPT ); Mon, 24 Feb 2020 17:30:35 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:47512 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726651AbgBXWaf (ORCPT ); Mon, 24 Feb 2020 17:30:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Fn9V5GgkUSEJykW5ByAGH87sM8JqmW0aHUBa1JUkvfE=; b=DOTQdzCPEsEBRz+ZBfbTrXdrDQ BKoavLNanfg3Si7S18JGTi8ExD+eIJaQ7AWs6IKqcXRHS1Nq5H3uD5JTNU1mPrNqLyW3d2XQnsCTk EEO4W9MAHwR9rx1VI4izaZrHAnXzYYs+NqhTVwEa536Lm/v5Bl4Oq6lzKoQQTSzYsiQFd+zGx1dWK vi1UzFjHME7KG71kDhaCh+F91OQ9JWSGorRXASxsB3am8sIZ1dvR1MeSCbaiC9LhIWYTW2nXByv2p Gnclj4OgenB0ojRVPcusY6NUdlXwooHF4W+WD7wNGbkHqUtrHHMbBCchyrfVtSTxBZIBlH0Ev3itj vefr+PDg==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1j6MFG-0005HO-2s; Mon, 24 Feb 2020 22:30:34 +0000 Date: Mon, 24 Feb 2020 14:30:34 -0800 From: Christoph Hellwig To: Eric Sandeen Cc: Christoph Hellwig , Christoph Hellwig , linux-xfs@vger.kernel.org, Eric Sandeen Subject: Re: [PATCH 1/6] xfs: remove the agfl_bno member from struct xfs_agfl Message-ID: <20200224223034.GA14361@infradead.org> References: <20200130133343.225818-1-hch@lst.de> <20200130133343.225818-2-hch@lst.de> <20200224220256.GA3446@infradead.org> <75eb13f6-8f96-a07d-f6ee-c648f8a3b38e@sandeen.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <75eb13f6-8f96-a07d-f6ee-c648f8a3b38e@sandeen.net> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org On Mon, Feb 24, 2020 at 02:27:49PM -0800, Eric Sandeen wrote: > On 2/24/20 2:02 PM, Christoph Hellwig wrote: > > On Thu, Jan 30, 2020 at 02:33:38PM +0100, Christoph Hellwig wrote: > >> struct xfs_agfl is a header in front of the AGFL entries that exists > >> for CRC enabled file systems. For not CRC enabled file systems the AGFL > >> is simply a list of agbno. Make the CRC case similar to that by just > >> using the list behind the new header. This indirectly solves a problem > >> with modern gcc versions that warn about taking addresses of packed > >> structures (and we have to pack the AGFL given that gcc rounds up > >> structure sizes). Also replace the helper macro to get from a buffer > >> with an inline function in xfs_alloc.h to make the code easier to > >> read. > >> > >> Signed-off-by: Christoph Hellwig > > > > Any chance we can pick this up for 5.6 to unbreak arm OABI? > > > > What did I miss, where's the report of actual breakage vs. > (I thought) harmless GCC complaints? The "harmless" gcc complaint is that the kernel build errors out as soon as XFS is enabled on arm OABI. Which is a good thing, as the file system would not be interoperable with other architectures if it didn't.